Closed Bug 604386 Opened 9 years ago Closed 9 years ago

Prune placeholder from text children

Categories

(Core :: Disability Access APIs, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: davidb, Assigned: surkov)

References

Details

Attachments

(2 files)

The placeholder gets in the way of our nice accessibility traversal and related expectations. This has led to disabling of tests and impedes bug 570275.
As per Alexander, need to look at nsIContent::GetChildren for HTML inputs...
(In reply to comment #1)
> As per Alexander, need to look at nsIContent::GetChildren for HTML inputs...

small correction, I think you need to override nsIContent::GetChildren for HTML inputs
David, if you'll get a wip then please file it here, I might continue it.
Right nsHTMLInputElement. I'll set you as owner for this bug, at least until I have a working DOMi.
Assignee: bolterbugz → surkov.alexander
Attached patch patchSplinter Review
Attachment #483450 - Flags: superreview?(bzbarsky)
Attachment #483450 - Flags: review?(bolterbugz)
Status: NEW → ASSIGNED
Comment on attachment 483450 [details] [diff] [review]
patch

The nsIContent API needs to take PRUint32 as well now, no?

The nsIAnonymousContentCreator change needs to document what set of values can be passed for the filter.

I'd prefer reversing the sense of the check in nsTextControlFrame and just moving 

   aElements.MaybeAppendElement(txtCtrl->GetPlaceholderNode());

into the if body with the reversed check.

sr=me with those changes.
Attachment #483450 - Flags: superreview?(bzbarsky) → superreview+
Attached patch patch2Splinter Review
bz's comments are addressed
Attachment #483460 - Flags: review?(bolterbugz)
Comment on attachment 483450 [details] [diff] [review]
patch

r=me. (Assuming you can address bz's comments)
It wasn't the solution I was thinking of, but it does leave the door open to adding more filters I guess?
Attachment #483450 - Flags: review?(bolterbugz) → review+
Attachment #483460 - Flags: review?(bolterbugz) → review+
(In reply to comment #8)
> It wasn't the solution I was thinking of, but it does leave the door open to
> adding more filters I guess?

sure, it's flexible approach.
Boris, are you ok with patch2, any other suggestions?
The only thing missing is the nsIAnonymousContentCreator documentation about filters.
(In reply to comment #11)
> The only thing missing is the nsIAnonymousContentCreator documentation about
> filters.

I wouldn't like to copy possible values into nsIAnonymousContentCreator from nsIContent, therefore I jsut refer to nsIContent::GetChildren there. Any ideas?
That looks good to me.
landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/16ef018faad1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.