Closed Bug 604522 Opened 14 years ago Closed 14 years ago

t/012throwables.t doesn't catch new user errors correctly

Categories

(Bugzilla :: Testing Suite, defect)

Product:
Bugzilla
Component:
Testing Suite
Version:
3.6.2
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.6

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

Attachments

(1 file)

patch, v1
2.61 KB, patch
mkanat
: review+
Details | Diff | Splinter Review
Attached patch patch, v1 — — Splinter Review 
In bug 575947, I introduced a new category of user errors thrown by AUTH_ERROR. But t/012throwables.t assumes that all AUTH_ERROR errors are code errors.
Flags: blocking4.0+
Flags: blocking3.6.3+
Attachment #483312 - Flags: review?(mkanat)
Comment on attachment 483312 [details] [diff] [review]
patch, v1

Awesome! Nice fix. :-)
Attachment #483312 - Flags: review?(mkanat) → review+
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
Assignee: testing → LpSolit
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Auth.pm
modified Bugzilla/Auth/Verify/DB.pm
modified t/012throwables.t
Committed revision 7543.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/Auth.pm
modified Bugzilla/Auth/Verify/DB.pm
modified t/012throwables.t
Committed revision 7441.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Auth.pm
modified Bugzilla/Auth/Verify/DB.pm
modified t/012throwables.t
Committed revision 7188.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: