Closed
Bug 604691
Opened 15 years ago
Closed 14 years ago
TP should allow non-numeric study ids
Categories
(Mozilla Labs Graveyard :: Test Pilot, defect, P1)
Mozilla Labs Graveyard
Test Pilot
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: jono, Unassigned)
Details
(Whiteboard: [qa-] needs-integration)
Attachments
(1 file)
|
5.06 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
Right now ids for studies must be integers, but there's no good reason for that - it's just because we're using parseInt. With arbitrary strings as IDs we can give studies much more natural ids to make analysis less confusing.
Severity: normal → minor
Priority: -- → P1
Target Milestone: -- → 1.1
RIAK supports random strings for bucket names as long as they don't contain slashes. The study IDs also become part of preference names and part of URLS so they can't have any characters that would mess that up, either. Everything should be fine if we just keep it to alphanumerics and underscores.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•15 years ago
|
Whiteboard: [qa-]
Attachment #500437 -
Flags: review?(dtownsend)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [qa-] → [qa-] needs-integration
|
||
Updated•14 years ago
|
Attachment #500437 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 4•14 years ago
|
||
Landed in mozilla-central: http://hg.mozilla.org/mozilla-central/rev/794627351d4e
Status: REOPENED → RESOLVED
Closed: 15 years ago → 14 years ago
Resolution: --- → FIXED
|
Assignee | |
Updated•9 years ago
|
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•