Shared GUID between survey and study won't work if survey submitted before study starts

RESOLVED FIXED in 1.1

Status

Mozilla Labs Graveyard
Test Pilot
P1
major
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: Jono Xia, Unassigned)

Tracking

unspecified

Details

(Whiteboard: data, needs-integration[qa-])

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
TestPilotBuiltinSurvey._prependMetadataToJson() attempts to include the related-study GUID with the survey metadata upload, if the survey has a related study.

However, if the study has not yet started, it will not yet have generated a GUID for itself, so this will be blank.  That means we won't be able to match up the survey with the associated study data like we want.

It shouldn't matter which of the two, the study or the survey, starts first or is submitted first.  The first one should generate the GUID and the second one should copy it.
(Reporter)

Updated

8 years ago
Severity: normal → major
Priority: -- → P1
Whiteboard: data
Target Milestone: -- → 1.1
(Reporter)

Comment 1

8 years ago
Done in http://hg.mozilla.org/labs/testpilot/rev/46cabbdc9eec with unit tests added to ensure that it works no matter which order they are generated in.
Whiteboard: data → data, needs-integration
(Reporter)

Comment 2

8 years ago
Created attachment 513569 [details] [diff] [review]
Patch fixing the bug
Attachment #513569 - Flags: review?(dtownsend)
Attachment #513569 - Flags: review?(dtownsend)
Attachment #513569 - Flags: review+
Attachment #513569 - Flags: approval2.0+
Landed: http://hg.mozilla.org/mozilla-central/rev/ffca7d5d2810
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Whiteboard: data, needs-integration → data, needs-integration[qa-]
(Assignee)

Updated

2 years ago
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in before you can comment on or make changes to this bug.