Closed
Bug 604697
Opened 14 years ago
Closed 13 years ago
Shared GUID between survey and study won't work if survey submitted before study starts
Categories
(Mozilla Labs Graveyard :: Test Pilot, defect, P1)
Mozilla Labs Graveyard
Test Pilot
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: jono, Unassigned)
Details
(Whiteboard: data, needs-integration[qa-])
Attachments
(1 file)
|
10.48 KB,
patch
|
mossop
:
review+
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
TestPilotBuiltinSurvey._prependMetadataToJson() attempts to include the related-study GUID with the survey metadata upload, if the survey has a related study. However, if the study has not yet started, it will not yet have generated a GUID for itself, so this will be blank. That means we won't be able to match up the survey with the associated study data like we want. It shouldn't matter which of the two, the study or the survey, starts first or is submitted first. The first one should generate the GUID and the second one should copy it.
Severity: normal → major
Priority: -- → P1
Whiteboard: data
Target Milestone: -- → 1.1
Done in http://hg.mozilla.org/labs/testpilot/rev/46cabbdc9eec with unit tests added to ensure that it works no matter which order they are generated in.
Whiteboard: data → data, needs-integration
Attachment #513569 -
Flags: review?(dtownsend)
|
||
Updated•13 years ago
|
Attachment #513569 -
Flags: review?(dtownsend)
Attachment #513569 -
Flags: review+
Attachment #513569 -
Flags: approval2.0+
|
|
||
Comment 3•13 years ago
|
||
Landed: http://hg.mozilla.org/mozilla-central/rev/ffca7d5d2810
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Whiteboard: data, needs-integration → data, needs-integration[qa-]
|
Assignee | |
Updated•8 years ago
|
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•