604719 - No warning when the downloaded file is larger than the space available

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mozilla/5.0 (Maemo;Linux armv71; rv:2.0b8pre) Gecko/20101015 Firefox/4.0b8pre Fennec/4.0b2pre
Mozilla/5.0 (Android; Linux armv71; rv2.0b8pre) Gecko/20101015 Firefox/4.0b8pre Fennec/4.0b2pre

1. go to http://www.thinkbroadband.com/download.html
2. click on the download for the 1 gb file

Expected: some sort of warning stating that the file is larger than the space available.
Actual : it will try to download and crash.

Considering that handhelds have limited space for downloads
1) if the user is unaware that the file is large it may help if there's some sort of warning before downloading a large file >75 megs.
2) if the download is larger than the space available, there should also be a notice or warning.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Note: edge case.  Android crashes, but I'm not 100 % sure if it's because of the download file size hitting the max, or something else.

Comment 2

[Aakash Desai [:aakashd]]

This isn't an edge case! It happens quite often and something to look out for since Fennec is 12MB. Brad, I remember there being a related bug, but I can't find it. Know the bug number if there is one?

Comment 3

[Madhava Enros [:madhava]]

It would be great to tell people, if we can, that they're not going to have room for the intended file.  It's very frustrating to get to near the end of a large download, only to find that you won't get the whole thing.  Presumably this is even more frustrating on mobile, where the data is more expensive.

Comment 4

[Doug Turner (:dougt)]

we need a wireframe and spec.

Comment 5

[Doug Turner (:dougt)]

madhava, marking 2.0+ since you want it.  clear it if you don't think it is that important.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

The current goal for this bug is: if we know the file download size, we should check disk space. If we don't know the download size, just try to save the file.

Basically, do the right thing if we can.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava - can we get a wireframe for this

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #2)
> This isn't an edge case! It happens quite often and something to look out for
> since Fennec is 12MB. Brad, I remember there being a related bug, but I can't
> find it. Know the bug number if there is one?

for what its worth, with bug 597579 we'll be downloading updates to the sd card. So you really will have to download something huge to hit this.

Comment 9

[Wesley Johnston (:wesj)]

Attachment: WIP

Still waiting for some UX feedback. This implements a system notification that says, "Download is too large to save", and cancels the download. I don't particularly like that message, and think maybe we need something more obvious visually (toaster popups would be nice for this stuff).

finkle, does doing this in downloads.js look ok, or do we want to handle this further up in toolkit or platform (and potentially catch other types of downloads that don't show up in the download manager)?

Comment 10

[Madhava Enros [:madhava]]

So yes - if we know the download size, let's check to see if there's room.  If
there is, it's totally transparent.  If it's too big, let's show a notification
in the place of the "Downloading" notification.

If we don't/can't know the size, let's just start downloading, as usual.

suggestion:
http://www.flickr.com/photos/madhava_work/5166616545/

tapping on the notification could take the user to the download manager, where
the download is listed as cancelled; this way, the user knows where to go to
restart it after they've cleared some space.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 489638 [details] [diff] [review]
WIP

Looks good to me

Comment 12

[Wesley Johnston (:wesj)]

Attachment: Patch V1

We don't know the size of the file when the download starts, so I put this check into the progress listener (highjacked from the android progress bars).

Also, I need to check if  nsILocalFile::diskSpaceAvailable is implemented anywhere (on my desktop it fails). Tested by forcing it to something small for now though.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed (r+ is really me)
http://hg.mozilla.org/mobile-browser/rev/39e695c27751

Comment 15

[timeless]

minor note: on the n900, ~/MyDocs generally disappears if you're plugged into a usb host (it's exported by the mass storage driver).

If you know the current transfer rate, you should be able to check to see if the available space will be exhausted within say 5 minutes at the current rate, if it is, it's probably worth warning the user. This should work for cases where you don't know the download size.

Comment 16

[Anna (Waverley)]

When I click on the download for the 1 gb file. I get "The connection has timed out" page. Can you please provide another webpage with files larger than 1GB?

Comment 17

[Catalin Suciu [:csuciu]]

Verified this on Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110911 Firefox/9.0a1 Fennec/9.0a1

There is no warning message displayed when trying to download a file larger than the space available. I had 100 Mb free space on device and started to download the 1 Gb file from http://www.thinkbroadband.com/download.html. When memory is full, download ends with a message box that has no message in it. 

Please see also related bug #686286.

Comment 18

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 19

[Richard Newman [:rnewman]]

It sounds like this is either done, or actionable. Either way it shouldn't sit at the bottom of the barrel -- it's painful for folks with low-storage devices.

Comment 20

[guptachiranjeev.13]

I would like to work on this bug, is this bug still open ?

Comment 21

[Josh Matthews [:jdm]]

Is there someone who is still a good mentor for is? Is this feature still desirable?

Comment 22

[Sebastian Kaspari (:sebastian; :pocmo)]

Currently there's no one who can actively mentor you here unfortunately. However if you feel like the attached patch has enough hints to get you started then let us know and we can at least find a reviewer for a new patch. Otherwise join us on IRC (#mobile [1]) and we can try to find an other bug for you.

[1] https://wiki.mozilla.org/IRC

For the "do we still want this" part I'll redirect to barbara: Making the story around downloads better has been discussed in the past. Maybe this is a candidate for this.

Comment 23

[Barbara Bermes [:barbara] - NI please!]

Absolutely, glad this is surfacing again. jdm, feel free to start working on it.


NI for Joe to let him know about this as well.

https://trello.com/c/4kVrZEa1

Comment 24

[Josh Matthews [:jdm]]

I was only asking in response to comment 7. Without a mentor, I doubt it's going anywhere.

Comment 25

[Josh Matthews [:jdm]]

Comment 20, I mean.

Comment 26

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 27

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.