604722 - Web Console won't open on chrome content

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Rob Campbell [:rc] (:robcee)]

Opening the Web Console on about: or chrome:// URIs gave us a chrome-enabled console. This stopped working as of October 14th.

Opening the Console on about:config now produces:

Error: (void 0) is undefined
Source File: chrome://browser/content/tabbrowser.xml
Line: 257

in Error Console.

Comment 1

[Rob Campbell [:rc] (:robcee)]

nominating for blocking final. This unintended feature turned out to be a real help for chrome development. Also, the regression should probably be found as it may cause other undesirable side-effects.

Comment 2

[Rob Campbell [:rc] (:robcee)]

the error message is from this bug:

[Bug 604210] Referencing property of undefined produces cryptic "(void 0) is undefined" message

Accessing a property of an undefined object.

Looks like we're passing wrappedJSObject to the contentWindow.document in HUDService.jsm, line 2967.

http://hg.mozilla.org/mozilla-central/annotate/00e90d9720c8/toolkit/components/console/hudservice/HUDService.jsm#l2967

trying unwrap() as I have a feeling this is no longer being wrapped in chrome documents.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Attachment: contentWindow.document unwrap

still need a unittest for this

Comment 4

[Rob Campbell [:rc] (:robcee)]

Attachment: unwrap(contentWindow.document)

missed the Patch flag

Comment 5

[:Gavin Sharp [email: [e-mail]]]

This wouldn't happen to be covered by the tests at http://hg.mozilla.org/mozilla-central/rev/29c228a4d7eb#l1.28 would it?

Comment 6

[Rob Campbell [:rc] (:robcee)]

no, although we filed bug 604431 and bug 604536 to fix code completion and turn those tests back on again. We didn't have a test to verify the console worked on chrome content pages because it was an unintended feature.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Attachment: removed unwrap

removed the unwrap function. Wasn't necessary after all.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

This should land with a test.

Comment 9

[Maniac Vlad Florin (:vladmaniac)]

Will certainly add a test in the spreadsheet

Comment 10

[Rob Campbell [:rc] (:robcee)]

Attachment: [checked-in] Chrome Console + Test

carrying review forward. Now with unittest. Going to do a couple more tests on the test code and then can land.

Comment 11

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 484702 [details] [diff] [review]
[checked-in] Chrome Console + Test

http://hg.mozilla.org/mozilla-central/rev/7a48f839ccf1