Closed Bug 604749 Opened 14 years ago Closed 13 years ago

TM: tune GC parameter to avoid GC runs in the shell for benchmarks

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: gwagner, Assigned: gwagner)

References

Details

Attachments

(1 file)

      No description provided.
Assignee: general → anygregor
Attached patch patchSplinter Review
Increase the lower WSS to 35MB and the growth factor to 3.5 instead of 3.
This avoids the remaining 2 GC runs within the benchmarks in the shell (short run in earley-boyer and a big one in splay)

TEST              COMPARISON            FROM                 TO             DETAILS

=============================================================================

** TOTAL **:      1.035x as fast    2711.6ms +/- 0.8%   2621.1ms +/- 0.7%     significant

=============================================================================

  v8:             1.035x as fast    2711.6ms +/- 0.8%   2621.1ms +/- 0.7%     significant
    crypto:       -                  268.8ms +/- 8.9%    260.1ms +/- 7.6% 
    deltablue:    -                  312.5ms +/- 2.3%    308.7ms +/- 0.5% 
    earley-boyer: 1.005x as fast     918.6ms +/- 0.2%    914.2ms +/- 0.1%     significant
    raytrace:     -                  492.6ms +/- 1.1%    488.4ms +/- 0.8% 
    regexp:       -                  166.7ms +/- 0.2%    166.7ms +/- 0.2% 
    richards:     -                  169.4ms +/- 0.5%    169.2ms +/- 0.6% 
    splay:        1.22x as fast      383.0ms +/- 0.6%    313.8ms +/- 3.2%     significant
This is with patch from bug 604747.
Depends on: 604747
Summary: TM: tune GC parameter to avoid GC runs in the shell → TM: tune GC parameter to avoid GC runs in the shell for benchmarks
I noticed recently that the Sunspider harness runs the V8 tests pretty differently than the V8 harness. The ordering of tests is different, and they're run for a different number of iterations. This probably has an impact on GC.
Still a valid non-TM bug?
Fixed by increasing the heap size for the shell.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: