Closed Bug 604778 Opened 12 years ago Closed 12 years ago

Don't export unnecessarily V8 headers to dist

Categories

(Core :: JavaScript Engine, defect)

x86
OS/2
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: wuno, Assigned: wuno)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (OS/2; Warp 4.5; rv:2.0b8pre) Gecko/20101015 Firefox/4.0b8pre
Build Identifier: 

V8 headers are exported to dist. However, due to setting the vpath in js/src/Makefile.in and the headers being in the vpath they are found also when they are not exported. Moreover, since at least some of the header files are designated with very common names like "utils.h" and "dist" is in the search path ahead of the system headers the V8 headers may be picked up erroneously when a system header includes another system header with the same name. 

Reproducible: Always
Version: unspecified → Trunk
Blocks: 558799
gal, since you reviewed the v8 dtoa patch in bug 558799, you may want to have a look at this patch. If you are the wrong person, please suggest me another reviewer. The patch works with linux and OS/2, other platforms I can't test but they should theoretically build as well.
Assignee: general → wuno
Status: NEW → ASSIGNED
Attachment #485852 - Flags: review?(gal)
Comment on attachment 485852 [details] [diff] [review]
don't export v8 headers

Looks good to me. Please tryserver before landing.
Attachment #485852 - Flags: review?(gal) → review+
(In reply to comment #2)
Thanks for the fast review.

> Please tryserver before landing.

Uhm, anybody to help me out? I've no checkin rights, sorry.
(In reply to comment #3)
> (In reply to comment #2)
> Thanks for the fast review.
> 
> > Please tryserver before landing.
> 
> Uhm, anybody to help me out? I've no checkin rights, sorry.

I'll do it later today.
Passed try server.  I landed it yesterday:

http://hg.mozilla.org/tracemonkey/rev/3e513dbf0882

Thanks for the patch!
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/3e513dbf0882
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.