604778 - Don't export unnecessarily V8 headers to dist

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; Warp 4.5; rv:2.0b8pre) Gecko/20101015 Firefox/4.0b8pre
Build Identifier: 

V8 headers are exported to dist. However, due to setting the vpath in js/src/Makefile.in and the headers being in the vpath they are found also when they are not exported. Moreover, since at least some of the header files are designated with very common names like "utils.h" and "dist" is in the search path ahead of the system headers the V8 headers may be picked up erroneously when a system header includes another system header with the same name. 

Reproducible: Always

Comment 1

[Walter Meinl]

Attachment: don't export v8 headers

gal, since you reviewed the v8 dtoa patch in bug 558799, you may want to have a look at this patch. If you are the wrong person, please suggest me another reviewer. The patch works with linux and OS/2, other platforms I can't test but they should theoretically build as well.

Comment 2

[Andreas Gal :gal]

Comment on attachment 485852 [details] [diff] [review]
don't export v8 headers

Looks good to me. Please tryserver before landing.

Comment 3

[Walter Meinl]

(In reply to comment #2)
Thanks for the fast review.

> Please tryserver before landing.

Uhm, anybody to help me out? I've no checkin rights, sorry.

Comment 4

[Nicholas Nethercote [inactive]]

(In reply to comment #3)
> (In reply to comment #2)
> Thanks for the fast review.
> 
> > Please tryserver before landing.
> 
> Uhm, anybody to help me out? I've no checkin rights, sorry.

I'll do it later today.

Comment 5

[Nicholas Nethercote [inactive]]

Passed try server.  I landed it yesterday:

http://hg.mozilla.org/tracemonkey/rev/3e513dbf0882

Thanks for the patch!

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/3e513dbf0882