JM: Allocate 64K chunks for code memory on Windows

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dmandelin, Assigned: dmandelin)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 483643 [details] [diff] [review]
Patch

On Windows, the practical minimum allocation from VirtualAlloc is 64K. The allocator we inherited from JSC allocates 16K chunks, so we are wasting 75% of our code memory allocations on Windows.
Attachment #483643 - Flags: review?(dvander)
Attachment #483643 - Flags: review?(dvander) → review+
(Assignee)

Comment 1

7 years ago
http://hg.mozilla.org/tracemonkey/rev/b36e628efeae
Whiteboard: fixed-in-tracemonkey

Comment 2

7 years ago
This was merged: http://hg.mozilla.org/mozilla-central/rev/b36e628efeae , so I assume it should be marked fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.