604830 - Plugin ID invalid message doesn't match the test

Status: RESOLVED FIXED

Description

[Stewart]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.19) Gecko/20090102 SeaMonkey/1.1.14
Build Identifier: ChatZilla 0.9.86 [SeaMonkey 1.1.14/0000000000]

According to the error message, an ID can contain alphanumeric characters, dash (_) and hyphen (-).

According to the code, an ID can contain alphabetic characters (no numbers), dash (_) and hyphen (-).

Oops?

Reproducible: Always

Steps to Reproduce:
1. In a plugin, set:
    plugin.id = "seamonkey-1_1_14-menu-fix";
   (for example)
2. Attempt to load plugin

Actual Results:  
Plugin <...> does not have a valid id. Plugin ids may only contain alphanumeric characters, underscores (_) and dashes (-).


Expected Results:  
Plugin “seamonkey-1_1_14-menu-fix” is now enabled.

Comment 1

[Stewart]

Created attachment 483682 [details] [diff] [review]
Fixes the ID check to match the error message

Comment 2

[Stewart]

Created attachment 483683 [details] [diff] [review]
Fixes the ID check to match the error message (v2)

Missed a spot. :(

Comment 3

[Glen Mailer]

It would be preferable to refactor that bit of code so that the conditions aren't all repeated.

Also, \w includes \d. Assuming your intention was to force the ID to start with a letter, the regex you want is /^[A-Za-z][\w-]*$/

Comment 4

[James Ross]

Created attachment 521215 [details] [diff] [review]
Add numbers to allowed regexp

Comment 5

[Samuel Sieb]

Comment on attachment 521215 [details] [diff] [review]
Add numbers to allowed regexp

It's a little odd that we're checking all the conditions twice...  (Yes, I do kind of see the reason for it there.)

Comment 6

[Jules Blok]

Why not just match it once and save the result in a local variable?

Comment 7

[James Ross]

Created attachment 522343 [details] [diff] [review]
Correct regexp and remove duplication of checks

Comment 8

[James Ross]

http://hg.mozilla.org/chatzilla/rev/0b940fd89a46