60489 - Context menu notifications do not get received from subframes

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect, P3)

Description

[Adam Lock]

This means the context menu listener interface does not call out to the embedder 
when the user clicks inside <FRAME> and <IFRAME> sections. This appears to be a 
DOM event bubbling issue (i.e DOM events do not bubble up from a frame to it's 
parent frame unless the parent is chrome).

Comment 1

[Adam Lock]

I have a patch for this problem, but I'm reworking it to use the new window
root object so I can add chrome DOM event listeners that don't get blown away 
every time the document is changed.

Comment 2

[Adam Lock]

Attachment: Context menu listener code changed to use window root event receiver

Comment 3

[David Hyatt]

I think we should just add an API to nsPIDOMWindow called GetWindowRoot, e.g.,

NS_IMETHOD GetWindowRoot(nsIWindowRoot** aResult)=0;

Then it could contain all of this code you had to write.  I envision you (and 
others) having to get the window root often, so we really should move that into 
a simple function that can be invoked from any DOM window.

+     nsCOMPtr<nsIDOMWindow> domWindow;
+     mWebBrowser->GetContentDOMWindow(getter_AddRefs(domWindow));
+     NS_ENSURE_TRUE(domWindow, NS_ERROR_FAILURE);
+ 
+     nsCOMPtr<nsPIDOMWindow> domWindowPrivate = do_QueryInterface(domWindow);
+     NS_ENSURE_TRUE(domWindowPrivate, NS_ERROR_FAILURE);
+     nsCOMPtr<nsIDOMWindowInternal> rootWindow;
+     domWindowPrivate->GetPrivateRoot(getter_AddRefs(rootWindow));
+     NS_ENSURE_TRUE(rootWindow, NS_ERROR_FAILURE);
+     nsCOMPtr<nsIChromeEventHandler> chromeHandler;
+     nsCOMPtr<nsPIDOMWindow> piWin(do_QueryInterface(rootWindow));
+     piWin->GetChromeEventHandler(getter_AddRefs(chromeHandler));
+     NS_ENSURE_TRUE(chromeHandler, NS_ERROR_FAILURE);

The code above could then be used as the body of the function.

Comment 4

[Adam Lock]

sr=hyatt. Changes checked in without the new helper method.

Comment 5

[Paul Wyskoczka]

Updating QA Contact

Comment 6

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 7

[David Epstein]

changed qa contact to dsirnapalli.

Comment 8

[dsirnapalli]

-- verified.