604917 - urlbar stops hiding after a while

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

With a local build of m-c 511c41f90373 + m-b de38e291c382, after I browsed around for a while, the urlbar stopped hiding.  I did a lot of stuff before this happened; loading a lot of pages, opening/closing/restoring some tabs, orientation changes, and device sleep/wake.  The urlbar stopped hiding until I force-killed fennec and restarted.

I tried to get short STR on both desktop and device, but was unsuccessful.

Comment 1

[Matt Brubeck (:mbrubeck)]

I also notice that after pulling out the sidebars, or pressing the menu button, the urlbar does not go away completely when dismissed.

Comment 2

[Matt Brubeck (:mbrubeck)]

(In reply to comment #1)
> I also notice that after pulling out the sidebars, or pressing the menu button,
> the urlbar does not go away completely when dismissed.

I filed bug 605484 for this problem.

I am also seeing the original problem reported here (urlbar sometimes gets stuck in locked state) but still haven't figured out STR.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Matt - has this been fixed?

Comment 4

[Matt Brubeck (:mbrubeck)]

I don't think so - I saw it just last night, using a local build from the tip of trunk, with the fix for bug 605484 included.  Still don't know the repro steps.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I've finally found a case where this happened.

Step to reproduce:
 * Load about:home
 * Click on the link at the bottom on the page "Give Feedback"
 * While the page _in a new tab_ is loading hit the ESCAPE key or on an Android device the back key
 
Actual result:
 * The new open tab is closed and the url bar is still locked

Expected result:
 * The new open tab is closed and the url bar is unlocked


This happen because we're not ensuring the url bar is unlock when we close the tabs, so this probably happen into others situations.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch ensure we're reverting the url bar state if needed

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 486779 [details] [diff] [review]
Patch

Grrr... lockToolbar / unlockToolbar really gets me down. So hard to find all the edge cases. Man, life would be SO much easier if didn't lock toolbar.

I wish we had a way to centralize the unlockToolbar calls, instead of having them spread out.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/ddce8f5d24dd

Comment 9

[Ayan Shah[:ashah]]

verified fixed on:
Mozilla/5.0(Android; Linux armv7l;rv2.0b8pre) Gecko/20101102 Firefox/4.0b8pre Fennec/4.0b3pre