Closed Bug 604941 Opened 14 years ago Closed 14 years ago

new toolbar border is too opaque or too dark

Categories

(Firefox :: Theme, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b8

People

(Reporter: asa, Assigned: dao)

References

Details

Attachments

(7 files)

Today's nightly build has a new border around the toolbar which is significantly darker than it ought to be. Screenshots attached.
Assignee: nobody → dao
Blocks: 544820
blocking2.0: --- → ?
Attached patch 40% @ 0.7 patchSplinter Review
Attachment #491180 - Flags: ui-review?(shorlander)
Attachment #491180 - Flags: review?(gavin.sharp)
Comment on attachment 491180 [details] [diff] [review]
40% @ 0.7 patch

The 40% grey is making it look rather washed out. Can we use a full black(or maybe 10%) at around .4 opacity instead?

This also makes the toolbar separator overlay the glass instead of the toolbar background. Although I am not sure if there is a way around that.
Attachment #491180 - Flags: ui-review?(shorlander) → ui-review-
(In reply to comment #3)
> Comment on attachment 491180 [details] [diff] [review]
> patch
> 
> The 40% grey is making it look rather washed out. Can we use a full black(or
> maybe 10%) at around .4 opacity instead?

This doesn't seem to work on dark glass. Screenshot coming up.
Attachment #491607 - Attachment description: rgba(10%,10%,10%,.4) → rgba(10%,10%,10%,.4) on dark background
Attachment #491607 - Attachment description: rgba(10%,10%,10%,.4) on dark background → 10% @ 0.4 / dark background
Attachment #491614 - Attachment description: rgba(10%,10%,10%,.4) on light background → 10% @ 0.4 / light background
Attachment #491611 - Attachment description: rgba(40%,40%,40%,.7) on dark background → 40% @ 0.7 / dark background
Attachment #491615 - Attachment description: rgba(40%,40%,40%,.7) on light background → 40% @ 0.7 / light background
(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 491180 [details] [diff] [review] [details]
> > patch
> > 
> > The 40% grey is making it look rather washed out. Can we use a full black(or
> > maybe 10%) at around .4 opacity instead?
> 
> This doesn't seem to work on dark glass. Screenshot coming up.

Thanks for the screenshots.

I don't think this is a problem. Having it blend more on darker backgrounds is to be expected and do to the nature of Glass I don't think we can expect to be optimal in every scenario.

Even the 40% gray seems to become indistinguishable from the dark glass instead of overlaying.
Attached patch 10% @ 0.4 patchSplinter Review
Attachment #491620 - Flags: ui-review?(shorlander)
Attachment #491620 - Flags: review?(gavin.sharp)
Attachment #491180 - Attachment description: patch → 40% @ 0.7 patch
Attachment #491180 - Flags: review?(gavin.sharp)
Comment on attachment 491620 [details] [diff] [review]
10% @ 0.4 patch

Looks good. Thank you!
Attachment #491620 - Flags: ui-review?(shorlander) → ui-review+
Comment on attachment 491620 [details] [diff] [review]
10% @ 0.4 patch

I don't understand what effect the background-clip change has (or what it's to supposed to have).

I don't think my review on these is very useful. You should probably just get Stephen to review simple CSS-only changes like this.
Attachment #491620 - Flags: review?(gavin.sharp) → review+
Attachment #491620 - Flags: approval2.0?
Attachment #491620 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/25f3b8529fd0
Status: NEW → RESOLVED
blocking2.0: ? → ---
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
Depends on: 617506
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: