Last Comment Bug 605021 - text-transform doesn't work on non-BMP characters (plane 1 characters, Deseret)
: text-transform doesn't work on non-BMP characters (plane 1 characters, Deseret)
Status: RESOLVED FIXED
: css1, css2
Product: Core
Classification: Components
Component: Layout: Text (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Jonathan Kew (:jfkthame)
:
Mentors:
http://test.csswg.org/suites/css2.1/2...
Depends on: 210501 736210
Blocks: css2.1-tests
  Show dependency treegraph
 
Reported: 2010-10-17 12:06 PDT by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2012-03-15 12:16 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch, handle surrogates in text-run case transformation (3.93 KB, patch)
2012-03-05 00:48 PST, Jonathan Kew (:jfkthame)
smontagu: review+
Details | Diff | Splinter Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2010-10-17 12:06:47 PDT
text-transform doesn't work on non-BMP characters (such as Deseret) because  nsCaseTransformTextRunFactory::RebuildTextRun and the code it uses operates on 16-bit code units.

This makes us fail:
http://test.csswg.org/suites/css2.1/20101001/html4/text-transform-bicameral-021.htm
http://test.csswg.org/suites/css2.1/20101001/html4/text-transform-bicameral-022.htm
http://test.csswg.org/suites/css2.1/20101001/xhtml1/text-transform-bicameral-021.xht
http://test.csswg.org/suites/css2.1/20101001/xhtml1/text-transform-bicameral-022.xht
Comment 1 Jonathan Kew (:jfkthame) 2012-03-05 00:48:39 PST
Created attachment 602828 [details] [diff] [review]
patch, handle surrogates in text-run case transformation

This depends on bug 210501 to provide the support for case-mapping of non-BMP character codes; once that infrastructure is done, we can fix text-transform to handle Deseret properly. :) (And any future casing alphabet that may get added to Plane 1...)
Comment 3 Marco Bonardo [::mak] 2012-03-15 07:55:39 PDT
https://hg.mozilla.org/mozilla-central/rev/6913a9ff86e1

Note You need to log in before you can comment on or make changes to this bug.