Closed Bug 605050 Opened 9 years ago Closed 9 years ago

Disable building accessibility on Android

Categories

(Firefox Build System :: General, defect)

All
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mwu, Assigned: mwu)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
This saves us 180kb on our APK.
Attachment #483878 - Flags: review?(khuey)
tracking-fennec: --- → ?
OS: Mac OS X → Android
Hardware: x86 → All
Comment on attachment 483878 [details] [diff] [review]
Patch

I'd prefer you changed http://mxr.mozilla.org/mozilla-central/source/configure.in#5008 so that all of the a11y disabling happens in the same place.
Attachment #483878 - Flags: review?(khuey)
Are you sure this is a good idea? I'm pretty sure the a11y APIs are necessary for things like voiceover to work correctly. Unless a11y is actually broken or useless (because of e10s?), I think we should be careful about disabling it for codesize...
I may be wrong at some point but David will correct me if I am.

1) We don't support builtin accessibility interface and we don't accessible with TalkBack screen reader
2) There is no AT-SPI2 nor Orca on Android and thus Firefox linux accessibility used on Gnome now doesn't run.

This is hot and urgent topic but I think the things won't be changed in Firefox 4 time frame.
Benjamin, thanks for the ping. Unfortunately Alexander is correct and we might as well compile for Android sans accessibility code until further notice.
Attached patch Patch, v2Splinter Review
Attachment #483878 - Attachment is obsolete: true
Attachment #485361 - Flags: review?(khuey)
Make sure that $target on Mac is *darwin*.  I'm not immediately sure what it is.
(In reply to comment #6)
> Make sure that $target on Mac is *darwin*.  I'm not immediately sure what it
> is.

Appears to be i386-apple-darwin8.0.0 (32bit crosscompile) and x86-64-apple-darwin10.4.0 (non-crosscompile).
Comment on attachment 485361 [details] [diff] [review]
Patch, v2

Requesting approval for a safe Android specific patch.
Attachment #485361 - Flags: approval2.0?
Attachment #485361 - Flags: approval2.0? → approval2.0+
pushed http://hg.mozilla.org/mozilla-central/rev/4169192b89a4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
tracking-fennec: ? → ---
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.