Closed Bug 605116 Opened 12 years ago Closed 12 years ago
Properly declare functions without arguments in npfunctions
Functions with no arguments should use (void) syntax. () syntax means unknown arguments. Here is an example of a warning that GCC gives: npfunctions.h:51: warning: function declaration isn't a prototype The attached patch fixes the problem.
Comment on attachment 483948 [details] [diff] [review] fix v1.0 This really needs to land upstream in http://code.google.com/p/npapi-headers/ so it can be shared with all implementations, but Josh can handle that.
Attachment #483948 - Flags: review?(bent.mozilla) → review?(joshmoz)
Go ahead and land this on mozilla-central now, I'll get it upstreamed.
Change pushed upstream. We actually considered this before but I mistakenly turned it down.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.