Closed
Bug 605116
Opened 14 years ago
Closed 14 years ago
Properly declare functions without arguments in npfunctions.h
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
3.66 KB,
patch
|
jaas
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
Functions with no arguments should use (void) syntax. () syntax means unknown arguments. Here is an example of a warning that GCC gives: npfunctions.h:51: warning: function declaration isn't a prototype The attached patch fixes the problem.
|
Assignee | |
Updated•14 years ago
|
Attachment #483948 -
Attachment is patch: true
Attachment #483948 -
Flags: review?(bent.mozilla)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → jacek
|
||
Comment 1•14 years ago
|
||
Comment on attachment 483948 [details] [diff] [review] fix v1.0 This really needs to land upstream in http://code.google.com/p/npapi-headers/ so it can be shared with all implementations, but Josh can handle that.
Attachment #483948 -
Flags: review?(bent.mozilla) → review?(joshmoz)
Attachment #483948 -
Flags: review?(joshmoz) → review+
Go ahead and land this on mozilla-central now, I'll get it upstreamed.
|
|
||
Updated•14 years ago
|
Attachment #483948 -
Flags: approval2.0+
Change pushed upstream. We actually considered this before but I mistakenly turned it down.
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/de37dc51f81c
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•