605173 - Download notification still remains even when the download has been canceled and deleted

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ayan Shah[:ashah]]

BuildID: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre) Gecko/20101018
Firefox/4.0b8pre Fennec /4.0b2pre 

STR:
1. Open fennec
2. Start a file download
3. Drag down the android notification bar and tap on the download progress notification.This will take you to the download manager. 
4. Here, tap on cancel. this will cancel your download
5. Then, tap on delete. This will delete the file from the system and the download manager.
6. Drag down the android notification bar.

Expected result:
The downloading notification should have been removed when the user has canceled and deleted the download.

Actual result:
The download notification still persists in the android notification bar.

Comment 1

[Alex Pakhotin (:alexp)]

Isn't this a dupe for bug 603378?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Can we get the Update notification to launch Fennec with a commandline param? 

fennec -alert <cookie>

so:
fennec -alert update

Then the commandline handler can run some code

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Oops, I mean in the download context, not the update context

Comment 4

[Alex Pakhotin (:alexp)]

(In reply to comment #2)
> Can we get the Update notification to launch Fennec with a commandline param?
> ...

Mark, I guess you meant to add this comment to the bug 604491?
Because this one looks just as a dupe for bug 603378 and should be already closed as fixed.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Yep

Comment 6

[Aakash Desai [:aakashd]]

I don't think this is a dupe as the duped-to bug has been verified, but I'm seeing this behavior on build:

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101115 Namoroka/4.0b8pre Fennec/4.0b3pre

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Working for me

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Not working for me in the Gecko/20101117 nightly build

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

The code seems to trying to hide the notifications, but I wonder if the "name" is wrong

Comment 10

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #7)
> Working for me

(In reply to comment #8)
> Not working for me in the Gecko/20101117 nightly build

Ayan, can we get a regression range?

Comment 11

[Alex Pakhotin (:alexp)]

Attachment: Fix

Can you spot the difference? :)

I believe this code worked before. Was preprocessor changed recently?
Anyway, I believe it should handle whitespace better.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

The code was changed recently in bug 604719, which added the whitespace issue. Yes, it should handle whitespace better.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/c7af5c33c019

Comment 14

[Anna (Waverley)]

VERIFIED FIXED:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110608 Firefox/7.0a1 Fennec/7.0a1 

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110607 Firefox/6.0a2 Fennec/6.0a2 

Device: HTC Desire Z (Android 2.2)