Now the dep builds are building with --enable-tests, we can move the running of make check from the "check" builds to the dep ones. Please can we run them in parallel for a day first, then we can turn off them on the dep builds after that. Note: Nightly builds don't run the make check step.
standard8: Can you confirm that you want a 'make check' step added to the following production builders? WINNT 5.2 comm-1.9.2 build MacOSX 10.5 comm-1.9.2 build Linux comm-1.9.2 build WINNT 5.2 comm-1.9.1 build MacOSX 10.5 comm-1.9.1 build Linux comm-1.9.1 build WINNT 5.2 comm-central build MacOSX 10.5 comm-central build Linux x86-64 comm-central build Linux comm-central build
John, we only want it on the trunk ones, i.e.: > WINNT 5.2 comm-central build > MacOSX 10.5 comm-central build > Linux x86-64 comm-central build > Linux comm-central build
Created attachment 484708 [details] [diff] [review] proposed config changes
Attachment #484708 - Flags: review?(gozer)
Comment on attachment 484708 [details] [diff] [review] proposed config changes Looks good. Only nit is that I would use getConfig() instead of pf.get() to get at the enable_checktests config variable for consistency
Attachment #484708 - Flags: review?(gozer) → review+
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
I was going to suggest that we disable make check on the current *comm-central check builders. However, it appears there's no option for that without hacking buildbotcustom, so its not worth it, and we can just put the effort into getting MozMill in packaged form.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.