605294 - Leak nsGlobalWindow hiding a focused iframe

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase (requires focus)

1. Load the testcase
2. Quit Firefox

Result: Leak nsGlobalWindow+

If I change focus before quitting, the leak goes away.  So this affects fuzzing more than it affects real life.  But I'd like to be able to fuzz for leaks ;)

Comment 1

[Johnny Stenback (:jst)]

Peter, can you have a look?

Comment 2

[Peter Van der Beken [:peterv]]

I'm having a hard time reproducing. I managed to make it leak once after trying about 20 times.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

I can reproduce this easily on Linux.
I could take a look.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

When shutting down we should just release the comptrs the singleton owns.

In normal cases focused windows changes all the time, so this isn't a "real"
leak bug.

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 497540 [details] [diff] [review]
patch

I don't suppose we could clear these when the iframe is hidden?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

That is another (open) bug and may be fixed as well. But I think there might
still be cases when we don't clear the variables before shutdown.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/dd9e50b46d31

Comment 8

[Jesse Ruderman]

Smaug, what's the bug number for the issue in comment 5 / comment 6?