Could potentially miss starting a restore

RESOLVED FIXED in Firefox 4.0b7

Status

()

Firefox
Session Restore
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: zpao, Assigned: zpao)

Tracking

Trunk
Firefox 4.0b7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Dao caught a mistake when reviewing bug 598221

Comment on attachment 483599 [details] [diff] [review]
Patch v0.2

>       try {
>         didStartLoad = true;
>-        // Get the tab title (set in restoreHistoryPrecursor) for later
>-        let label = aTab.label;
>         browser.webNavigation.gotoIndex(activeIndex);
>-        // gotoIndex will force the "loading" string, so set the title
>-        aTab.label = label;
>       }
>       catch (ex) {
>         // ignore page load errors

It looks like didStartLoad = true; should be outside of the try block. And
maybe there should be a didStartLoad = false; in the catch block? Not relevant
for this bug, though.

I haven't seen this problem in the wild, but there's potential that we might not start another restore when we should.
Attachment #484377 - Flags: review? → review?(dao)

Updated

8 years ago
Attachment #484377 - Flags: review?(dao) → review+
Attachment #484377 - Flags: approval2.0? → approval2.0+
Pushed http://hg.mozilla.org/mozilla-central/rev/f21edbeb7855
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8

Updated

8 years ago
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in before you can comment on or make changes to this bug.