Closed
Bug 605299
Opened 14 years ago
Closed 14 years ago
Could potentially miss starting a restore
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 4.0b7
People
(Reporter: zpao, Assigned: zpao)
Details
Attachments
(1 file)
1.29 KB,
patch
|
dao
:
review+
Dolske
:
approval2.0+
|
Details | Diff | Splinter Review |
Dao caught a mistake when reviewing bug 598221 Comment on attachment 483599 [details] [diff] [review] Patch v0.2 > try { > didStartLoad = true; >- // Get the tab title (set in restoreHistoryPrecursor) for later >- let label = aTab.label; > browser.webNavigation.gotoIndex(activeIndex); >- // gotoIndex will force the "loading" string, so set the title >- aTab.label = label; > } > catch (ex) { > // ignore page load errors It looks like didStartLoad = true; should be outside of the try block. And maybe there should be a didStartLoad = false; in the catch block? Not relevant for this bug, though. I haven't seen this problem in the wild, but there's potential that we might not start another restore when we should.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #484377 -
Flags: review?
Assignee | ||
Updated•14 years ago
|
Attachment #484377 -
Flags: review? → review?(dao)
Updated•14 years ago
|
Attachment #484377 -
Flags: review?(dao) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #484377 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #484377 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 2•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/f21edbeb7855
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
Updated•14 years ago
|
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•