Closed Bug 605340 Opened 9 years ago Closed 9 years ago

"ASSERTION: Can't find flow containing this frame???"

Categories

(Core :: Layout, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla2.0b7
Tracking Status
blocking1.9.2 --- .13+
status1.9.2 --- .13-fixed
blocking1.9.1 --- .16+
status1.9.1 --- .16-fixed

People

(Reporter: jruderman, Assigned: mats)

References

(Blocks 2 open bugs)

Details

(4 keywords)

Attachments

(4 files)

Attached file testcase
###!!! ASSERTION: Can't find flow containing this frame???: 'Error', file layout/generic/nsTextFrameThebes.cpp, line 2158
Attached file stack trace
Assignee: nobody → matspal
Severity: normal → critical
Keywords: crash, regression
OS: Mac OS X → All
Hardware: x86 → All
Attached patch crashtest.diffSplinter Review
Attached patch Patch rev. 1Splinter Review
Silly mistake - 'mLastFlowIndex' became out-of-bounds.
As I understand it, 'mLastFlowIndex' is just an optimization used
as a hint when mapping content -> mapped flow, so any valid index
is correct.  The last index seems like a good choice.

With this patch the testcase still asserts but those will be fixed
in bug 604843.  This patch is independent of that bug though.

I'm adding "[run=0xNNNNNNNN]" to the text frame dump since I often
find it useful when debugging.
Attachment #484280 - Flags: review?(roc)
Attachment #484280 - Flags: approval2.0?
Blocks: 571995
Depends on: 604843
Comment on attachment 484280 [details] [diff] [review]
Patch rev. 1

Test?
Attachment #484280 - Flags: review?(roc)
Attachment #484280 - Flags: review+
Attachment #484280 - Flags: approval2.0?
Attachment #484280 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/fe4243e45cf1
http://hg.mozilla.org/mozilla-central/rev/898db83dc637
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Marking this regression a branch blocker for qa verification because bug 571995 is a blocker.
blocking1.9.1: --- → .16+
blocking1.9.2: --- → .13+
You need to log in before you can comment on or make changes to this bug.