605360 - Correlation reports with invalid signature never finish loading / should handle errors

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Might be invalid or a duplicate of an existing bug I can't find, but on the off chance that it's not...

STR:

1. Load https://crash-stats.stage.mozilla.com/report/list?version=Firefox%3A3.6.9&build_id=&query_search=signature&query_type=exact&query=&date=2010-10-18%2016%3A00%3A00&range_value=2&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=&signature=&missing_sig=NULL&page=1
2. Click on the "Correlations" tab
3. Look at the "Loading..." lines

Actual:

18:34:46.244: Network: GET https://crash-stats.stage.mozilla.com/correlation/ajax/cpu/Firefox/3.6.9/Windows%20NT// [HTTP/1.1 500 Internal Server Error 168ms]
18:34:46.253: Network: GET https://crash-stats.stage.mozilla.com/correlation/ajax/addon/Firefox/3.6.9/Windows%20NT// [HTTP/1.1 500 Internal Server Error 179ms]
18:34:46.262: Network: GET https://crash-stats.stage.mozilla.com/correlation/ajax/module/Firefox/3.6.9/Windows%20NT// [HTTP/1.1 500 Internal Server Error 215ms]

Expected:

If the data's unavailable, it should time out and say so, rather than keep spinning

(Happens on prod, too, sorry: http://crash-stats.mozilla.com/report/list?range_value=2&range_unit=weeks&date=2010-10-18%2016%3A00%3A00&signature=&missing_sig=NULL&version=Firefox%3A3.6.9)

Comment 1

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

I thought this was fixed just last week in Bug 599195?

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to comment #1)
> I thought this was fixed just last week in Bug 599195?

After discussing with vish_moz in irc, sounds like this isn't really a problem with the data being there or not but just that we're not handling the error and showing "loading" forever.

I have a patch to catch any and all errors and replace the loading spinners with "error, could not load data" coming up momentarily.

Comment 3

[Robert Helmer [:rhelmer]]

Attachment: stop loading status and display error message on HTTP errors

I also took this opportunity to reduce the duplication in here. I could do that as a separate patch if you want, seems pretty self-contained and not very risky.

I've done minimal testing on this in my dev environment using the staging database.

Comment 4

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Comment on attachment 484859 [details] [diff] [review]
stop loading status and display error message on HTTP errors

Looks good.  Thanks for tackling that!

Comment 5

[Robert Helmer [:rhelmer]]

Attachment: do not call socSortCorrelation(...) in error case

Comment 6

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Comment on attachment 484863 [details] [diff] [review]
do not call socSortCorrelation(...) in error case

I missed that in the first review as well.  Good catch!

Comment 7

[Robert Helmer [:rhelmer]]

Checked into trunk:
Committed revision 2634.

And also 1.7reversion branch:
Committed revision 2635.

Comment 8

[Robert Helmer [:rhelmer]]

(In reply to comment #0)
> 1. Load
> https://crash-stats.stage.mozilla.com/report/list?version=Firefox%3A3.6.9&build_id=&query_search=signature&query_type=exact&query=&date=2010-10-18%2016%3A00%3A00&range_value=2&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=&signature=&missing_sig=NULL&page=1

...

> Expected:
> 
> If the data's unavailable, it should time out and say so, rather than keep
> spinning

You should now get an error message instead (including after clicking on the "Load" buttons) on stage.

Not sure how to find working correlation reports, but I confirmed that it at least tries to load a report if there are no HTTP errors:

https://crash-stats.stage.mozilla.com/report/list?range_value=2&range_unit=weeks&date=2010-10-20%2014%3A00%3A00&signature=UserCallWinProcCheckWow&version=Firefox%3A3.6.11

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; it now displays "error, could not load data".