Closed Bug 605383 Opened 14 years ago Closed 13 years ago

custom command arguments completion works but doesn't get executed on pressing enter

Categories

(Skywriter Graveyard :: Command Line, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: amarnus, Unassigned)

Details

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_4; en-US) AppleWebKit/534.3 (KHTML, like Gecko) Chrome/6.0.472.63 Safari/534.3
Build Identifier: 0.9a1

Turns out argsPromise doesn't get resolved on time and that prevents execution. No error/warning comes up. With a little debugging, I noticed that changing 'return types.fromString(assignment.value, assignment.param.type);' to 'return new Promise().resolve(assignment.value);' fixes the bug.

But I understand the solution is not elegant. So decided to report it.

Reproducible: Always

Steps to Reproduce:
1. Create a command param with a custom type
2. Add an extension with nam: custom type and ep: typehint
3. Define getHint function inside the custom pointer class
4. Rebuild Bespin
5. Now, try to type in the command in the command line, choose an auto-completed argument (by pressing tab or using the mouse) and press Enter

Actual Results:  
Command line gets cleared and Command (to which params of custom type has been added) is expected to be executed.

Expected Results:  
Command line gets cleared but the command doesn't get executed (no errors or warnings)
ACETRANSITION

The Skywriter project has merged with Ajax.org's Ace project (the full server part of which is their Cloud9 IDE project). Background on the change is here:

http://mozillalabs.com/skywriter/2011/01/18/mozilla-skywriter-has-been-merged-into-ace/

The bugs in the Skywriter product are not necessarily relevant for Ace and quite a bit of code has changed. For that reason, I'm closing all of these bugs. Problems that you have with Ace should be filed in the Ace issue tracker at GitHub:

https://github.com/ajaxorg/ace/issues
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.