605385 - Peacekeeper stringFilter test is slow with yarr

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:

1)  hg clone http://hg.mozilla.org/users/mpalmgren_mozilla.com/peacekeeper
2)  Load the run.html from the result.
3)  Select "stringFilter" under "string"
4)  Click "Run selected"

ACTUAL RESULTS: 3500 or so, just like Safari (no surprise there)

EXPECTED RESULTS: 20000 or so, like Opera and Chrome.

Comment 1

[Nathan Froyd [:froydnj]]

I think this is https://bugs.webkit.org/show_bug.cgi?id=64202

Do we have a good way to import new versions of YARR?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I've been toying around with updating Yarr, but haven't got anything workable yet. I'll CC you if/when I officially file a bug for it.

Comment 3

[Till Schneidereit [:till]]

I get ~55k on a 2.7Ghz rMBP.

Sadly, Chrome doesn't run the test (saying "TypeError: Property 'setupBenchmark' of object [object global] is not a function"), so I can't compare to that.

Safari gets ~74k, however, so we could be quite a bit faster here, probably.

Comment 4

[Chris Peterson [:cpeterson]]

This YARR bug is no longer relevant because we replaced YARR with irregexp in Firefox 32 (bug 976446).

Unfortunately, irregexp significantly regressed stringFilter performance, which is tracked in bug 1024132.

Firefox 30 = 67567 ops
Beta 31    = 68493 ops
Aurora 32  =  4249 ops
Nightly 33 =  4298 ops
Safari 7   = 78740 ops