Closed Bug 605406 Opened 13 years ago Closed 13 years ago

Small issues with in-tree freetype2 build

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b8

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

Dont build files that are included in ftbase.c
868 bytes, patch
pavlov
: review+
khuey
: review+
blassey
: approval2.0+
Details | Diff | Splinter Review
Don't put libfreetype twice on the link command line
581 bytes, patch
khuey
: review+
blassey
: approval2.0+
Details | Diff | Splinter Review 
When trying to build with the patches in bug 603370 and its dependencies on android, I found out 2 small issues, one of which I'm really wondering how it hasn't hit us before:
- freetype2 is given twice on the link command (not a big problem)
- some functions are included twice in the in-tree freetype2, because some .c files are built from Makefile.in, while they already are built from ftbase.c which includes them.
Attachment #484252 - Flags: review?(khuey)
When building against in-tree cairo, the cairo ld flags already contain freetype fd flags, in which case adding them again is redundant.
Assignee: nobody → mh+mozilla
Attachment #484253 - Flags: review?(khuey)
Blocks: 603370
Attachment #484252 - Flags: review?(khuey) → review+
Attachment #484252 - Flags: approval2.0?
Attachment #484253 - Flags: approval2.0?
Attachment #484252 - Flags: approval2.0? → approval2.0+
Attachment #484253 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/c2c173d7091c
http://hg.mozilla.org/mozilla-central/rev/3671421f858c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.