Remove "configure bugmail" from bugmail (newchangedmail)

RESOLVED FIXED in Bugzilla 4.2

Status

()

--
enhancement
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Martijn.Ras, Assigned: Martijn.Ras)

Tracking

3.6.2
Bugzilla 4.2
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Hello,

I receive lots of complaints from my users about the following part of the emails they receive:

  -- 
  Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email

I hacked these out of newchangedmail.txt.tmpl.

I think it would be useful if the content and layout could be controlled the administration interface.

Mazzel,

Martijn.

Comment 1

8 years ago
Why would an admin interface be useful? This would affect all users at once, and would bring back the old Bugzilla 2.x behavior. You could as well edit the template directly, as you did already. IMO, a better alternative would be to remove the line

 Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email

entirely. This URL doesn't need to be in each bugmail, and people who want to edit their email prefs can follow the URL to the bug, and then from here go to the prefs panel. mkanat?

I don't think it makes sense to make other parts of the email template optional.
Assignee: administration → email-notifications
Component: Administration → Email Notifications
(Assignee)

Comment 2

8 years ago
Created attachment 484273 [details] [diff] [review]
Removes the line "Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email" from the templates.

Indeed, just removing the line is better ... no need to make things more complex than necessary.

Comment 3

8 years ago
Comment on attachment 484273 [details] [diff] [review]
Removes the line "Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email" from the templates.

Putting your patch in our radar.
Attachment #484273 - Flags: review?(mkanat)
Attachment #484273 - Flags: review?(LpSolit)

Updated

8 years ago
Summary: Make parts of newchangedmail.txt.tmpl optional and controlled through the administration interface → Remove "configure bugmail" from bugmail (newchangedmail)

Comment 4

8 years ago
Comment on attachment 484273 [details] [diff] [review]
Removes the line "Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email" from the templates.

Nice to see this URL which we never use going away. Thanks for the patch! :) r=LpSolit
Attachment #484273 - Flags: review?(mkanat)
Attachment #484273 - Flags: review?(LpSolit)
Attachment #484273 - Flags: review+

Updated

8 years ago
Assignee: email-notifications → Martijn.Ras
Status: NEW → ASSIGNED
Flags: approval+
Target Milestone: --- → Bugzilla 4.2

Comment 5

8 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/email/bugmail.html.tmpl
modified template/en/default/email/bugmail.txt.tmpl
Committed revision 7552.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 6

8 years ago
We should also remove the ---- ---- Stuff from the "You are receiving this email because" line now, though, since it doesn't have to be separated from anything anymore.

Comment 7

8 years ago
(In reply to comment #6)
> We should also remove the ---- ---- Stuff

Yeah, I thought about that too. :) Done.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/email/bugmail.txt.tmpl
Committed revision 7554.
We get a good number of complaints already for people not knowing where to change their e-mail settings. I worry that removing this will increase that... I guess we'll find out.

Comment 9

8 years ago
(In reply to comment #8)
> We get a good number of complaints already for people not knowing where to
> change their e-mail settings.

See, those people are unable to see the link when it's right under their nose. And the link annoys everybody who uses Bugzilla daily, because you change your email settings maybe once every two years. It's a good thing it goes away. :)
You need to log in before you can comment on or make changes to this bug.