Links from chrome do not work

RESOLVED FIXED

Status

Mozilla Labs
Prism
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Matthew Gertner, Assigned: Matthew Gertner)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
If a chrome interface contains links that should open in the browser (e.g. auto-update manual link), they don't open in Prism apps. Correct behavior would be to open them in the default browser.
(Assignee)

Comment 1

7 years ago
Created attachment 484281 [details] [diff] [review]
Override default openURL in contentAreaUtils.js to open links externally

I tried to reverse the behavior of Prism so that all links are opened externally (by setting network.protocol-handler.expose-all to false) and then using the special link handling in webrunner.js to open links internally when appropriate. Unfortunately this caused responses from form submissions to open in the default browser instead of in Prism, and it looks like this would be quite difficult to fix. So I fell back on this solution.
Attachment #484281 - Flags: review?(mark.finkle)
(Assignee)

Updated

7 years ago
Attachment #484281 - Attachment is patch: true
Attachment #484281 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 484281 [details] [diff] [review]
Override default openURL in contentAreaUtils.js to open links externally

Be on the lookout for any other bustage since we are not overriding the full JS file
Attachment #484281 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

7 years ago
Sending        chrome/Makefile.in
Adding         chrome/content/overrides
Adding         chrome/content/overrides/contentAreaUtils.js
Sending        chrome/jar.mn
Transmitting file data ...
Committed revision 76016.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.