Pref to disable fullscreen

RESOLVED FIXED

Status

Mozilla Labs
Prism
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Matthew Gertner, Assigned: Matthew Gertner)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Some applications might not want to use the fullscreen keyboard shortcut.
(Assignee)

Comment 1

8 years ago
Created attachment 484285 [details] [diff] [review]
Add prism.shortcut.fullScreen.disable pref
Attachment #484285 - Flags: review?(mark.finkle)
Comment on attachment 484285 [details] [diff] [review]
Add prism.shortcut.fullScreen.disable pref

prefs.getBoolPref will throw an exception if the pref is not found. You should add this pref to the preferences JS file too, defaulted to false.

Or you can wrap the code in a try/catch

r+ with nit fixed
Attachment #484285 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

8 years ago
I did change preferences.js but I forgot to include it in the patch.

Replacing      chrome/content/webrunner.js
Sending        defaults/preferences/preferences.js
Transmitting file data ..
Committed revision 75956.
(Assignee)

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.