605533 - Traceback: ValueError: invalid literal for int() with base 10

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P5)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

On https://preview.addons.mozilla.org/z/en-US/developers/addon/8585/ownership, doing:

POST:<QueryDict: {u'eula': [u'URL'], u'form-0-user': [u'[e-mail]'], u'form-1-role': [u'5'], u'form-2-user': [u"Enter a new author's email address"], u'form-1-DELETE': [u'on'], u'form-1-position': [u'1'], u'form-0-id': [u'20088'], u'form-1-user': [u'[e-mail]'], u'form-2-listed': [u'on'], u'form-2-role': [u'5'], u'has_eula': [u'on'], u'builtin': [u'1', u'2', u'3', u'4', u'5', u'6', u'7', u'0'], u'form-1-id': [u'990899218156='], u'csrfmiddlewaretoken': [u'47f11c8614fb9ce8cf200d72860f7f7c'], u'form-2-position': [u'0'], u'form-2-DELETE': [u'on'], u'form-0-DELETE': [u'on'], u'form-TOTAL_FORMS': [u'2'], u'form-INITIAL_FORMS': [u'2'], u'form-0-listed': [u'on'], u'name': [u'Custom License'], u'form-0-position': [u'0'], u'form-0-role': [u'5'], u'form-1-listed': [u'on'], u'has_priv': [u'on']}>,

triggers:

Traceback (most recent call last):

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 77, in wrapper
    return f(*args, **kw)

  File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 69, in wrapper
    return f(*args, **kw)

  File "/usr/lib/python2.6/contextlib.py", line 34, in __exit__
    self.gen.throw(type, value, traceback)

  File "/data/amo_python/www/preview/zamboni/apps/amo/models.py", line 37, in skip_cache
    yield

  File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 69, in wrapper
    return f(*args, **kw)

  File "/data/amo_python/www/preview/zamboni/apps/amo/decorators.py", line 24, in wrapper
    return func(request, *args, **kw)

  File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 39, in wrapper
    return f(request, addon_id, addon, *args, **kw)

  File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 54, in wrapper
    return f(request, addon_id, addon, *args, **kw)

  File "/data/amo_python/www/preview/zamboni/apps/devhub/views.py", line 111, in ownership
    user_form = AuthorFormSet(request.POST or None, queryset=qs)

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/forms/models.py", line 423, in __init__
    super(BaseModelFormSet, self).__init__(**defaults)

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/forms/formsets.py", line 47, in __init__
    self._construct_forms()

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/forms/formsets.py", line 97, in _construct_forms
    self.forms.append(self._construct_form(i))

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/forms/models.py", line 442, in _construct_form
    connection=connections[self.get_queryset().db])

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/db/models/fields/subclassing.py", line 53, in inner
    return func(*args, **kwargs)

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/db/models/fields/subclassing.py", line 53, in inner
    return func(*args, **kwargs)

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/db/models/fields/__init__.py", line 306, in get_db_prep_lookup
    value = self.get_prep_lookup(lookup_type, value)

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/db/models/fields/__init__.py", line 292, in get_prep_lookup
    return self.get_prep_value(value)

  File "/data/amo_python/www/preview/zamboni/vendor/src/django/django/db/models/fields/__init__.py", line 476, in get_prep_value
    return int(value)

ValueError: invalid literal for int() with base 10: '990899218156='

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

I see this also on http://addons.allizom.org/fr/firefox/addon/hellspy/reviews/format:rss; separate bug?

Comment 3

[Vincent Agnano [:vinyll]]

Attachment: stephen3000-ownership.png

https://addons-dev.allizom.org/en-US/developers/addon/stephen3000/ownership

Comment 4

[Vincent Agnano [:vinyll]]

Attachment: reviews-rss.png

Hellspy reviews RSS

Comment 5

[Vincent Agnano [:vinyll]]

This URL seems to work just fine https://addons.allizom.org/fr/firefox/addon/hellspy/reviews/format:rss
Same for https://addons-dev.allizom.org/en-US/developers/addon/stephen3000/ownership
Have bug been fixed among others?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Vincent Agnano [:vinyll] from comment #5)
> This URL seems to work just fine
> https://addons.allizom.org/fr/firefox/addon/hellspy/reviews/format:rss
> Same for
> https://addons-dev.allizom.org/en-US/developers/addon/stephen3000/ownership
> Have bug been fixed among others?

Probably; it's been 3 years...

Comment 8

[Vincent Agnano [:vinyll]]

@andym confirmed me that this was fixed a while ago using https://pypi.python.org/pypi/django-quieter-formset in Zamboni.