Closed Bug 605544 Opened 10 years ago Closed 10 years ago

Style buttons, menulists, and toggles for Android Theme

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(fennec2.0b2+)

VERIFIED FIXED
Tracking Status
fennec 2.0b2+ ---

People

(Reporter: wesj, Assigned: wesj)

References

Details

Attachments

(9 files, 7 obsolete files)

41.98 KB, image/png
Details
50.92 KB, image/png
Details
33.64 KB, image/png
Details
73.65 KB, image/png
Details
29.44 KB, patch
wesj
: review+
Details | Diff | Splinter Review
558 bytes, patch
mfinkle
: review+
Details | Diff | Splinter Review
2.13 KB, patch
mbrubeck
: review+
Details | Diff | Splinter Review
15.83 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review
68.09 KB, image/png
Details
Attached image Screenshot
Blocks: 575403
Comment on attachment 484389 [details] [diff] [review]
Buttons, menulist buttons, and textfields

* Remove the old drop markers
* Rename the new image -> dropmarker-hdpi.png
* -moz-border-radius -> border-radius
* We should also rename urlbar-bg.png -> button-bg.png to make it more explicit
Attached patch Fixes (obsolete) — Splinter Review
Attachment #484389 - Attachment is obsolete: true
Attachment #484428 - Flags: review?(mark.finkle)
Attached image Toggles screenshot
Comment on attachment 484428 [details] [diff] [review]
Fixes

Whoops. Made a little mistake with the final patch here. I'll try to finish up the rest of the prefs stuff in this bug, and put up another patch in a minute.
Attachment #484428 - Flags: review?(mark.finkle)
* Remove any of the now unused "toggleoff-*" and "toggleon-*" images
* Update the jar.mn with the correct image names (still using
dropmarker-42.png) and remove the toggleoff-* / toggleon-* images and remove
the dropmarker-* images
Attached patch Patch (obsolete) — Splinter Review
Final version... hopefully
Attachment #484428 - Attachment is obsolete: true
Attachment #484466 - Flags: review?(mark.finkle)
Attached image Spinbuttons
And just for fun, a screenshot of spin-buttons in rtl mode
Attached patch Patch v4 (obsolete) — Splinter Review
Forgot to include an image, and found a simpler way to fix textbox styling. Mostly I just forgot to include an image though.
Attachment #484466 - Attachment is obsolete: true
Attachment #484515 - Flags: review?(mark.finkle)
Attachment #484466 - Flags: review?(mark.finkle)
Comment on attachment 484515 [details] [diff] [review]
Patch v4

preferences-header.png -> settings-header-bg.png

r+ with the name change
Attachment #484515 - Flags: review?(mark.finkle) → review+
Attached patch Patch with nits (obsolete) — Splinter Review
Attachment #484515 - Attachment is obsolete: true
Attachment #484531 - Flags: review+
This causes an issue with notification boxes I didn't realize at first. Maybe fix in a followup.
Attached patch Final fixSplinter Review
Arrgh. Real final fixes.
Attachment #484531 - Attachment is obsolete: true
Attachment #484535 - Flags: review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/e59def595bdf

Still needs fixes for notification button fixes
tracking-fennec: --- → 2.0b2+
Assignee: nobody → wjohnston
We need to override these styles so they don't apply to prompts or the search engine popup.
Attachment #484602 - Flags: review?(mark.finkle)
Attachment #484602 - Flags: review?(mark.finkle) → review+
Comment on attachment 484602 [details] [diff] [review]
patch: Override new styles in prompt buttons

Pushed: http://hg.mozilla.org/mobile-browser/rev/23efcb09e9c4
fixes the buttons in notifications and changes the color/bgcolor of the notifications too
Attachment #484604 - Flags: review?(mbrubeck)
Attachment #484604 - Flags: review?(mbrubeck) → review+
Attached patch kill button-dark (obsolete) — Splinter Review
This patch gets rid of the last uses of button-dark and toggle-dark, and the associated styles and images.
Attachment #484920 - Flags: review?(mark.finkle)
Attached image screenshot: error console (obsolete) —
This is with the "kill button-dark" patch applied.
Changed the radio background from blue to inset.  Also added the search-bar style to the error console field, and tweaked the border.
Attachment #484920 - Attachment is obsolete: true
Attachment #484957 - Flags: review?(mark.finkle)
Attachment #484920 - Flags: review?(mark.finkle)
Attachment #484954 - Attachment is obsolete: true
Comment on attachment 484957 [details] [diff] [review]
kill button-dark v2

This is better than current and good enough for b2. We can tweak more later.

So nice to remove all this CSS and images
Attachment #484957 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/9aad13180e67

Marking this resolved; we can file followup bugs for any further changes.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified on Build:

Mozilla/5.0(Android; Linux armv7l; rv:2.0b8pre) Gecko/20101021 Firefox/4.0b8pre Fennec/4.0b2pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.