605582 - [Edit page] Character counter missing for add-on summary

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://preview.addons.mozilla.org/z/en-US/developers/addon/228507/edit
2. Click on edit button for 'Basic Information'
3. Compare the add-on summary section to http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/03_edit_listing_expanded.png

observed behavior:
Character counter is missing in the implementation. See screenshot.

Comment 1

[Wil Clouser [:clouserw]]

This should be a generic counter so we can use it all over

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Is the maximum length for the add-on Summary to be 500 characters?

Comment 3

[Wil Clouser [:clouserw]]

Summary is 250 chars, description has no limit.  Sorry, the mockup is just a placeholder.

Comment 4

[Jeff Balogh (:jbalogh)]

gkoberger just did this for the submit flow.

Comment 5

[Gregory Koberger (:gkoberger)]

cvan- I didn't go with the jQuery plugin used for input (NobleCount or something like that), since it was a huge file.  However, since this is going to be in more than one place, it might be worth it.

Alternatively, you could work with this:
https://github.com/jbalogh/zamboni/commit/b5565b0b72ac0c43c6c6121eca4336f23786fcbd

Comment 6

[Christopher Van Wiemeersch [:cvan]]

Committed: https://github.com/jbalogh/zamboni/commit/cb6e685

Comment 7

[krupa raj[:krupa]]

I still don't see the character counter @ https://addons.allizom.org/z/en-US/developers/addon/255411/edit

Am I missing something?

Comment 8

[krupa raj[:krupa]]

Attachment: missing character counter

Comment 9

[Wil Clouser [:clouserw]]

It appears once you focus the box.  I agree it should appear by default.

Comment 10

[Christopher Van Wiemeersch [:cvan]]

Yep, I had it appear on focus. On step 3 of the add-on submission process, there are multiple textareas displayed for each localized language. Should these textareas be toggled via the L10n switcher (like on the Add-on Edit page)? If not, then we can add a separate character count below each textarea.

Regardless, I'll show the character count by default and, where applicable, update the count when the locale is changed and a new textarea is made visible.

Comment 11

[Wil Clouser [:clouserw]]

(In reply to comment #10)
> Yep, I had it appear on focus. On step 3 of the add-on submission process,
> there are multiple textareas displayed for each localized language. Should
> these textareas be toggled via the L10n switcher (like on the Add-on Edit
> page)? If not, then we can add a separate character count below each textarea.
> 
> Regardless, I'll show the character count by default and, where applicable,
> update the count when the locale is changed and a new textarea is made visible.

Makes no difference to me as long as the number reflects what is in the box

Comment 12

[Christopher Van Wiemeersch [:cvan]]

Fixed in commit https://github.com/jbalogh/zamboni/commit/88dfcfd

Comment 13

[krupa raj[:krupa]]

Attachment: screenshot 12/30

In the mocks, character counter is:

* left-aligned.
* count is not in bold.

Comment 14

[Christopher Van Wiemeersch [:cvan]]

http://people.mozilla.com/~chowse/drop/amo/devtools/v3/addon_submission/03_description.png

For the same 'Summary' field on Submission Step 3, the '255 characters left' is right aligned, and the character count is set in a darker gray.

In the mockup for the Basic Info add-on edit page (http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/03_edit_listing_expanded.png), the character counter is left aligned and the character count is in the same style.

The mockups are inconsistent. Which style should we adopt?

Comment 15

[Chris Howse [:chowse]]

(In reply to comment #14)
> The mockups are inconsistent. Which style should we adopt?

For colors and fonts, use the style and wording of addon_submission/03_description.png (darker grey count, lighter gray words).

For positioning, how difficult would it be to support both variations? If the count is the only subtext present (i.e. when editing), it makes sense to have it on the left (in reading order, easier to notice when scanning). When the input hint is there (i.e. when submitting), having it on the right seems more sensible than on a separate line (less vertical space, hint draws your eyes to the right).

Comment 16

[Christopher Van Wiemeersch [:cvan]]

Character counter styles have been updated accordingly: https://github.com/jbalogh/zamboni/commit/26b3d17

Comment 17

[krupa raj[:krupa]]

verified fixed @ https://addons.allizom.org/z/en-US/developers/addon/amplify-test-addon-20110104/edit

Comment 18

[krupa raj[:krupa]]

Attachment: post-fix screenshot