Closed Bug 605642 Opened 14 years ago Closed 14 years ago

Style the findbar for Android theme

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: wesj, Assigned: wesj)

Details

Attachments

(2 files, 2 obsolete files)

Attached patch Patch v1 (obsolete) — Splinter Review
New icons and style for buttons.
New style for textbox.
Style the form-helper textbox.
Attached image Screenshots
Form helper is on top
Attached patch Fix v2. (obsolete) — Splinter Review
Oops. Forgot to mark this for review?
Attachment #484512 - Attachment is obsolete: true
Attachment #484905 - Flags: review?(mark.finkle)
Comment on attachment 484905 [details] [diff] [review]
Fix v2.

You might need to rebase this patch. Other stuff landed on the search boxes.
Rename prev.png -> previous.png
Remove unsued previous and next images and entries from jar.mn
Add new images to jar.mn
Rememeber to hg add the new images (I don't see them in the patch)
Attachment #484905 - Flags: review?(mark.finkle) → review-
Attached patch Fix v3Splinter Review
Whoops. Now with images.
Attachment #484905 - Attachment is obsolete: true
Attachment #484922 - Flags: review?(mark.finkle)
Comment on attachment 484922 [details] [diff] [review]
Fix v3

prev.png > previous-hdpi.png
next.png -> next-hdpi.png

I added a simple tap-color and condensed the disabled rule.
Attachment #484922 - Flags: review?(mark.finkle) → review+
pushed with tweaks:
http://hg.mozilla.org/mobile-browser/rev/376e48b58db0
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101021 Namoroka/4.0b8pre Fennec/4.0b2pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101021 Namoroka/4.0b8pre Fennec/4.0b2pre
Status: RESOLVED → VERIFIED
bugspam
Assignee: nobody → wjohnston
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: