605668 - Page offset to the left after two-Finger page-up/down gesture on a zoomed-in right side of the page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101019 Namoroka/4.0b8pre Fennec/4.0b2pre

Steps to Reproduce:
1. Go to www.google.com/news
2. Zoom in to the "Recent" section of the right column
3. Use a two-finger gesture to move to the bottom of the page

Actual Results:
The left side of the zoomed-in page is shown.

Expected Results:
The right side of the zoomed-in page is shown.

Comment 1

[Aakash Desai [:aakashd]]

Why is this being minus'd?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Is this bad enough to not ship Fennec? Does it happen in frequent situations? Is two-finger gesture busted in general?

2.0- means we would take a patch to fix this, but it doesn't seem critical to block the release. If this happens in more cases it might warrant 2.0+

Comment 3

[Aakash Desai [:aakashd]]

This happens on the page-up gesture as well. 

As for the reasoning to minus this...if a user is on a large/long page, they're more likely to zoom within it than most other pages. It also makes it more likely that they're going to want to get to the bottom or top of the page at some point as well. It's a rather obvious breakage for the basic functionality of this feature and it doesn't make a whole lot of sense to me for it to be minus'd from the final version of Mobifx 4.0.

Comment 4

[Aakash Desai [:aakashd]]

Also, if this is not going to fixed, then it needs to be relnoted for the release.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch just fixes the scrollContentToBottom & scrollContentToTop methods to not change the xposiotion unless it's passed into the method. We do pass in the x position (x=0) when laoding a new foreground page.

Works fine in the google news test case and loading new pages when the current page is not at 0, 0

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/8a59ab907820

For Aakash...

Comment 7

[Aakash Desai [:aakashd]]

beautiful. verified FIXED on build:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101105 Namoroka/4.0b8pre Fennec/4.0b2pre

Comment 8

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=13792 added to regression test this bug