Closed Bug 605671 Opened 9 years ago Closed 9 years ago

Intermittent failure in test_permmanager_notifications.js | exception thrown from do_timeout callback: ReferenceError: obs is not defined

Categories

(Core :: Networking: Cookies, defect)

x86
Windows Server 2003
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: philor, Assigned: dwitte)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1287520576.1287527877.12248.gz
WINNT 5.2 mozilla-central debug test xpcshell on 2010/10/19 13:36:16
s: w32-ix-slave24

TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\tests\extensions\cookie\test\unit\test_permmanager_notifications.js | test failed (with xpcshell return code: 0), see following log:
  >>>>>>>
  ### XPCOM_MEM_LEAK_LOG defined -- logging leaks to c:\docume~1\cltbld\locals~1\temp\tmptctic3\runxpcshelltests_leaks.log
pldhash: for the table at address 07F37070, the given entrySize of 48 probably favors chaining over double hashing.
pldhash: for the table at address 090037E8, the given entrySize of 56 probably favors chaining over double hashing.
TEST-INFO | (xpcshell/head.js) | test 1 pending
TEST-INFO | (xpcshell/head.js) | test 2 pending
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/extensions/cookie/test/unit/test_permmanager_notifications.js | [anonymous : 47] 2 == 2
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/extensions/cookie/test/unit/test_permmanager_notifications.js | [anonymous : 48] 1287521280593 == 1287521280593
TEST-INFO | (xpcshell/head.js) | test 2 finished
TEST-INFO | (xpcshell/head.js) | test 2 pending
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/extensions/cookie/test/unit/test_permmanager_notifications.js | [anonymous : 64] 2 == 2
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/extensions/cookie/test/unit/test_permmanager_notifications.js | [anonymous : 65] 1287521290593 == 1287521290593
TEST-INFO | (xpcshell/head.js) | test 2 finished
TEST-INFO | (xpcshell/head.js) | test 2 pending
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/extensions/cookie/test/unit/test_permmanager_notifications.js | [anonymous : 51] 0 == 0
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/extensions/cookie/test/unit/test_permmanager_notifications.js | [anonymous : 52] 2 == 2
TEST-INFO | (xpcshell/head.js) | test 2 finished
TEST-INFO | (xpcshell/head.js) | test 2 pending
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/extensions/cookie/test/unit/test_permmanager_notifications.js | [anonymous : 77] test/permission-notify == test/permission-notify
TEST-INFO | (xpcshell/head.js) | test 2 finished
TEST-INFO | (xpcshell/head.js) | test 2 pending
TEST-PASS | e:/builds/moz2_slave/mozilla-central-win32-debug-unittest-xpcshell/build/xpcshell/tests/extensions/cookie/test/unit/test_permmanager_notifications.js | [anonymous : 86] true == true
TEST-INFO | (xpcshell/head.js) | test 2 finished
TEST-INFO | (xpcshell/head.js) | test 1 finished
TEST-INFO | (xpcshell/head.js) | exiting test
TEST-UNEXPECTED-FAIL | e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\head.js | exception thrown from do_timeout callback: ReferenceError: obs is not defined - See following stack:
JS frame :: e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\head.js :: do_throw :: line 420
JS frame :: e:\builds\moz2_slave\mozilla-central-win32-debug-unittest-xpcshell\build\xpcshell\head.js :: anonymous :: line 140
TEST-INFO | (xpcshell/head.js) | exiting test
Attached patch fixSplinter Review
Pretty simple stuff, using all the generator goo in head_cookies.js. This passes locally. <3 yield!
Assignee: nobody → dwitte
Status: NEW → ASSIGNED
Attachment #485084 - Flags: review?(josh)
Comment on attachment 485084 [details] [diff] [review]
fix

Mmm, I like it. r=jdm
Attachment #485084 - Flags: review?(josh) → review+
http://hg.mozilla.org/mozilla-central/rev/8d1aca43c54b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.