The default bug view has changed. See this FAQ.

Make config.cgi?ctype=rdf faster

RESOLVED FIXED in Bugzilla 3.6

Status

()

Bugzilla
Bugzilla-General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

({perf})

3.6.2
Bugzilla 3.6
Bug Flags:
approval +
approval4.0 +
approval3.6 +

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 484590 [details] [diff] [review]
patch, v1

Bug 553266 was a great step to make config.cgi faster (from 13s to 5s, based on mkanat's testing with a copy of bmo). Another great step is to avoid the repeated calls to correct_urlbase() and |urlbase FILTER xml|, which appear for *each* piece of data displayed in config.cgi. With the attached patch, I get an improvement of 30%!

Before:
------
Profile of config.cgi for 20.1s, executing 5388138 statements and 1553559 subroutine calls.

10.2s	Template::Provider::::__ANON__[template/en/default/config.rdf.tmpl:286]


After:
-----
Profile of config.cgi for 13.9s, executing 3431795 statements and 922481 subroutine calls.

6.30s	Template::Provider::::__ANON__[template/en/default/config.rdf.tmpl:290] Template::Provider::__ANON__
Attachment #484590 - Flags: review?(timello)
Comment on attachment 484590 [details] [diff] [review]
patch, v1

It looks good! I've tested it and it works fine. Good improvement.
Attachment #484590 - Flags: review?(timello) → review+

Updated

7 years ago
Flags: approval?
(Assignee)

Updated

7 years ago
Flags: approval?
Flags: approval4.0+
Flags: approval3.6+
Flags: approval+
(Assignee)

Comment 2

7 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/config.rdf.tmpl
modified template/en/default/filterexceptions.pl
Committed revision 7551.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified template/en/default/config.rdf.tmpl
modified template/en/default/filterexceptions.pl
Committed revision 7447.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified template/en/default/config.rdf.tmpl
modified template/en/default/filterexceptions.pl
Committed revision 7192.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.