Last Comment Bug 605693 - Make config.cgi?ctype=rdf faster
: Make config.cgi?ctype=rdf faster
Status: RESOLVED FIXED
: perf
Product: Bugzilla
Classification: Server Software
Component: Bugzilla-General (show other bugs)
: 3.6.2
: All All
: -- normal (vote)
: Bugzilla 3.6
Assigned To: Frédéric Buclin
: default-qa
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-19 18:30 PDT by Frédéric Buclin
Modified: 2010-10-20 05:10 PDT (History)
2 users (show)
LpSolit: approval+
LpSolit: approval4.0+
LpSolit: approval3.6+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (6.44 KB, patch)
2010-10-19 18:30 PDT, Frédéric Buclin
timello: review+
Details | Diff | Splinter Review

Description Frédéric Buclin 2010-10-19 18:30:51 PDT
Created attachment 484590 [details] [diff] [review]
patch, v1

Bug 553266 was a great step to make config.cgi faster (from 13s to 5s, based on mkanat's testing with a copy of bmo). Another great step is to avoid the repeated calls to correct_urlbase() and |urlbase FILTER xml|, which appear for *each* piece of data displayed in config.cgi. With the attached patch, I get an improvement of 30%!

Before:
------
Profile of config.cgi for 20.1s, executing 5388138 statements and 1553559 subroutine calls.

10.2s	Template::Provider::::__ANON__[template/en/default/config.rdf.tmpl:286]


After:
-----
Profile of config.cgi for 13.9s, executing 3431795 statements and 922481 subroutine calls.

6.30s	Template::Provider::::__ANON__[template/en/default/config.rdf.tmpl:290] Template::Provider::__ANON__
Comment 1 Tiago Mello [:timello] 2010-10-19 19:13:13 PDT
Comment on attachment 484590 [details] [diff] [review]
patch, v1

It looks good! I've tested it and it works fine. Good improvement.
Comment 2 Frédéric Buclin 2010-10-20 05:10:41 PDT
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/config.rdf.tmpl
modified template/en/default/filterexceptions.pl
Committed revision 7551.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified template/en/default/config.rdf.tmpl
modified template/en/default/filterexceptions.pl
Committed revision 7447.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified template/en/default/config.rdf.tmpl
modified template/en/default/filterexceptions.pl
Committed revision 7192.

Note You need to log in before you can comment on or make changes to this bug.