605693 - Make config.cgi?ctype=rdf faster

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

Attachment: patch, v1

Bug 553266 was a great step to make config.cgi faster (from 13s to 5s, based on mkanat's testing with a copy of bmo). Another great step is to avoid the repeated calls to correct_urlbase() and |urlbase FILTER xml|, which appear for *each* piece of data displayed in config.cgi. With the attached patch, I get an improvement of 30%!

Before:
------
Profile of config.cgi for 20.1s, executing 5388138 statements and 1553559 subroutine calls.

10.2s	Template::Provider::::__ANON__[template/en/default/config.rdf.tmpl:286]


After:
-----
Profile of config.cgi for 13.9s, executing 3431795 statements and 922481 subroutine calls.

6.30s	Template::Provider::::__ANON__[template/en/default/config.rdf.tmpl:290] Template::Provider::__ANON__

Comment 1

[Tiago Mello [:timello]]

Comment on attachment 484590 [details] [diff] [review]
patch, v1

It looks good! I've tested it and it works fine. Good improvement.

Comment 2

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/config.rdf.tmpl
modified template/en/default/filterexceptions.pl
Committed revision 7551.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified template/en/default/config.rdf.tmpl
modified template/en/default/filterexceptions.pl
Committed revision 7447.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified template/en/default/config.rdf.tmpl
modified template/en/default/filterexceptions.pl
Committed revision 7192.