605850 - Top outside corners of Personal toolbar need border radius when tabs are not on top.

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101019 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101019 Firefox/4.0b8pre

According to the mockups, when tabs are not on top, (and the bookmark toolbar is visible) the Personal Toolbar and the Tabs toolbar have a background color, with the top left and right corners being rounded. 

This is similar to bug 589259, but that only handled the tabs on top case.

Reproducible: Always

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: v1

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 484706 [details] [diff] [review]
v1

>diff --git a/browser/themes/winstripe/browser/browser-aero.css b/browser/themes/winstripe/browser/browser-aero.css
>--- a/browser/themes/winstripe/browser/browser-aero.css
>+++ b/browser/themes/winstripe/browser/browser-aero.css
>@@ -110,16 +114,21 @@
>     border-top-left-radius: 3.5px;
>     border-top-right-radius: 3.5px;
>   }

Can you just add the selector to the above rule?

>+  #navigator-toolbox:not([tabsontop="true"]) > #PersonalToolbar {
>+    border-top-left-radius: 3.5px;
>+    border-top-right-radius: 3.5px;
>+  }

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: v2

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 485058 [details] [diff] [review]
v2

>   #main-window[sizemode="normal"]:not([inFullscreen="true"]) #navigator-toolbox[tabsontop="true"] > #nav-bar:not(:-moz-lwtheme),
>   #main-window[sizemode="normal"]:not([inFullscreen="true"]) #navigator-toolbox[tabsontop="true"]:not([customizing]) > #nav-bar[collapsed="true"] + toolbar:not(:-moz-lwtheme),
>-  #main-window[sizemode="normal"]:not([inFullscreen="true"]) #navigator-toolbox[tabsontop="true"]:not([customizing]) > #nav-bar[collapsed="true"] + #customToolbars + #PersonalToolbar:not(:-moz-lwtheme) {
>+  #main-window[sizemode="normal"]:not([inFullscreen="true"]) #navigator-toolbox[tabsontop="true"]:not([customizing]) > #nav-bar[collapsed="true"] + #customToolbars + #PersonalToolbar:not(:-moz-lwtheme),
>+  #main-window[sizemode="normal"] #navigator-toolbox:not([tabsontop="true"]) > #PersonalToolbar {

Please add :not([inFullscreen="true"]) like in the previous selectors. :not(:-moz-lwtheme) also wouldn't hurt, although it's not going to matter in practice.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: v3

Comment 6

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/7fe27fecda73