Closed Bug 605850 Opened 9 years ago Closed 9 years ago

Top outside corners of Personal toolbar need border radius when tabs are not on top.

Categories

(Firefox :: Theme, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 4.0b8

People

(Reporter: KWierso, Assigned: KWierso)

Details

Attachments

(1 file, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101019 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101019 Firefox/4.0b8pre

According to the mockups, when tabs are not on top, (and the bookmark toolbar is visible) the Personal Toolbar and the Tabs toolbar have a background color, with the top left and right corners being rounded. 

This is similar to bug 589259, but that only handled the tabs on top case.

Reproducible: Always
Attached patch v1 (obsolete) — Splinter Review
Attachment #484706 - Flags: review?(mano)
Attachment #484706 - Flags: review?(mano) → review?(dao)
Comment on attachment 484706 [details] [diff] [review]
v1

>diff --git a/browser/themes/winstripe/browser/browser-aero.css b/browser/themes/winstripe/browser/browser-aero.css
>--- a/browser/themes/winstripe/browser/browser-aero.css
>+++ b/browser/themes/winstripe/browser/browser-aero.css
>@@ -110,16 +114,21 @@
>     border-top-left-radius: 3.5px;
>     border-top-right-radius: 3.5px;
>   }

Can you just add the selector to the above rule?

>+  #navigator-toolbox:not([tabsontop="true"]) > #PersonalToolbar {
>+    border-top-left-radius: 3.5px;
>+    border-top-right-radius: 3.5px;
>+  }
Attached patch v2 (obsolete) — Splinter Review
Attachment #484706 - Attachment is obsolete: true
Attachment #485058 - Flags: review?(dao)
Attachment #484706 - Flags: review?(dao)
Comment on attachment 485058 [details] [diff] [review]
v2

>   #main-window[sizemode="normal"]:not([inFullscreen="true"]) #navigator-toolbox[tabsontop="true"] > #nav-bar:not(:-moz-lwtheme),
>   #main-window[sizemode="normal"]:not([inFullscreen="true"]) #navigator-toolbox[tabsontop="true"]:not([customizing]) > #nav-bar[collapsed="true"] + toolbar:not(:-moz-lwtheme),
>-  #main-window[sizemode="normal"]:not([inFullscreen="true"]) #navigator-toolbox[tabsontop="true"]:not([customizing]) > #nav-bar[collapsed="true"] + #customToolbars + #PersonalToolbar:not(:-moz-lwtheme) {
>+  #main-window[sizemode="normal"]:not([inFullscreen="true"]) #navigator-toolbox[tabsontop="true"]:not([customizing]) > #nav-bar[collapsed="true"] + #customToolbars + #PersonalToolbar:not(:-moz-lwtheme),
>+  #main-window[sizemode="normal"] #navigator-toolbox:not([tabsontop="true"]) > #PersonalToolbar {

Please add :not([inFullscreen="true"]) like in the previous selectors. :not(:-moz-lwtheme) also wouldn't hurt, although it's not going to matter in practice.
Attached patch v3Splinter Review
Attachment #485058 - Attachment is obsolete: true
Attachment #485413 - Flags: review?(dao)
Attachment #485058 - Flags: review?(dao)
Attachment #485413 - Flags: review?(dao) → review+
Attachment #485413 - Flags: approval2.0?
Assignee: nobody → kwierso
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #485413 - Flags: approval2.0? → approval2.0+
Whiteboard: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/7fe27fecda73
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: checkin-needed
Target Milestone: --- → Firefox 4.0b8
You need to log in before you can comment on or make changes to this bug.