checksum packager.mk target breaks pretty names

RESOLVED FIXED in mozilla2.0b7

Status

RESOLVED FIXED
8 years ago
7 months ago

People

(Reporter: jhford, Assigned: jhford)

Tracking

Trunk
mozilla2.0b7
x86_64
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This is because of the string containing spaces.

Running this patch through try server before asking r? and a?
Created attachment 484877 [details] [diff] [review]
fix prettynames

This patch fixes an issue where using pretty names breaks uploading because the CHECKSUM_FILE variable isn't properly wrapped in quotes.

I have also unhidden the invocation of checksum.py.

Asking for approval because this will break the build for the next beta off mozilla-central (currently beta 8).
Attachment #484877 - Flags: review?(ted.mielczarek)
Attachment #484877 - Flags: approval2.0?
Comment on attachment 484877 [details] [diff] [review]
fix prettynames

*sigh*, I should have noticed that!
Attachment #484877 - Flags: review?(ted.mielczarek)
Attachment #484877 - Flags: review+
Attachment #484877 - Flags: approval2.0?
Attachment #484877 - Flags: approval2.0+
Landed: http://hg.mozilla.org/mozilla-central/rev/cb47678d6351
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Target Milestone: mozilla2.0b8 → mozilla2.0b7

Updated

7 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.