Stop sticking virtual stuff in C++ blocks in nsIDOMWindowUtils

RESOLVED FIXED in mozilla2.0b7

Status

()

Core
DOM
P1
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla2.0b7
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(blocking2.0 beta7+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

See bug 596743 comment 7.

This needs to block b7, sadly... I'll see if I can write up a patch for this tonight.
blocking2.0: --- → beta7+
Blocks: 596743
Created attachment 484955 [details] [diff] [review]
Don't put stuff that changes the vtable in a C++ block.
Attachment #484955 - Flags: review?(roc)
Assignee: nobody → bzbarsky
Priority: -- → P1
Whiteboard: [need review]
Attachment #484955 - Flags: review?(roc) → review+
Attachment #484955 - Attachment is obsolete: true
Created attachment 484960 [details] [diff] [review]
Don't put stuff that changes the vtable in a C++ block.
Comment on attachment 484960 [details] [diff] [review]
Don't put stuff that changes the vtable in a C++ block.

With more feeling.
Attachment #484960 - Flags: review?(roc)
Attachment #484960 - Flags: review?(roc) → review+
Pushed http://hg.mozilla.org/mozilla-central/rev/91c3496d58cb

And on relbranch: http://hg.mozilla.org/mozilla-central/rev/702a5ebcb7a6
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [need review]
Target Milestone: --- → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.