606050 - hook failure checking in to shadow-central

Status: VERIFIED FIXED

(mozilla.org Graveyard :: Server Operations, task)

Description

[Daniel Veditz [:dveditz]]

I can check out of shadow-central, but not into it due to hook failure. When trying to merge up to a current mozilla-central I get:

  pushing to ssh://hgpvt.mozilla.org/shadow-central/
  searching for changes
  remote: adding changesets
  remote: adding manifests
  remote: adding file changes
  remote: added 12524 changesets with 54523 changes to 15564 files (+15 heads)
  remote: Unrecognized tree!  I don't know how to check closed status for
shadow-central.
  remote: transaction abort!
  remote: rollback completed
  remote: abort: pretxnchangegroup.a_treeclosure hook failed
  abort: unexpected response: empty string

Do we need the hook to check for closed status?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

If we want to be able to block landings, and have a tinderbox tree where the builds are being reported to then http://hg.mozilla.org/hgcustom/hghooks/file/default/mozhghooks/treeclosure.py#l23 needs updating and deploying to hg.m.o.

If we don't want to block, or don't have a tinderbox tree, then this needs to go to Server Ops to have the hook removed.

Comment 2

[Reed Loden [:reed]]

Either way, this is an IT thing and not a RelEng thing. :)

Comment 3

[Daniel Veditz [:dveditz]]

I asked Aravind prior to filing and he said RelEng maintained the hook code.

I don't know what nthomas means by "don't have a tinderbox tree". We do have http://tinderbox.mozilla.org/showbuilds.cgi?tree=Shadow-Central and want it to work. I don't know what all a hook is used for so I can't say we don't need one, but we could probably live without the part that checks the tree for closure if that's the only broken bit. But if it's easier to fix by making the tree closeable that's great too.

Would updating that file in hg.m.o help a repo on hgpvt.m.o? Or are we simply missing files on the new repo host?

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Well kinda, http://hg.mozilla.org/hgcustom/hghooks/log/c152e1609289/mozhghooks/treeclosure.py but it's a trivial change to add shadow-central so lets not quible. The "don't have a tinderbox tree" was just "lack of familiarity with shadow central" + "be verbose about requirements".

There can be multiple hooks applied to a repo that run before or after changes are pushed. The treeclosure hook just looks at the tinderbox waterfall to see if the tree is CLOSED before allowing changes. AFAIK that hook can be applied to any repo we like, regardless of the hosting location.

The tree might be closed because an infrastructure downtime or because the code is broken (or about to be by a big landing!). We'd (I'd) certainly like it working for the first reason, so without further ado ..

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Add shadow-central to treeclosure hook

Untested, but I think it should work. I added the necessary goo to the tinderbox tree.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 484982 [details] [diff] [review]
Add shadow-central to treeclosure hook

http://hg.mozilla.org/hgcustom/hghooks/rev/a4b4de9fa1d4

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Aravind, please update the tree closure hook on the shadow-central.

Comment 8

[Aravind Gottipati [:aravind]]

Done.

Comment 9

[Daniel Veditz [:dveditz]]

Thanks -- it works: VERIFIED.