Name crypto background thread so it can be identified by OS tools

RESOLVED INVALID

Status

Cloud Services
Firefox Sync: Crypto
--
enhancement
RESOLVED INVALID
8 years ago
7 years ago

People

(Reporter: cjones, Assigned: cjones)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

See bug 606062 comment 0: having a named Sync thread can be very useful when gross profiling, because with named threads can simply look at which threads are chewing CPU in a tool like |top| and say, e.g., "oh, the Sync thread is quiet".
Created attachment 484968 [details] [diff] [review]
Name the Weave/Sync background thread "gecko.Sync"
Assignee: nobody → jones.chris.g
Attachment #484968 - Flags: review?(mconnor)
The thread in question isn't where Sync does its work, it's just where we do the crypto. I suggest calling it "gecko.ServicesCrypto" or something similar.

Note that this should land in fx-sync (we periodically merge to m-c). It will thus live in the add-on code as well which may be installed on older 4.0 betas that don't have nsIThread::newNamedThread. We might want to retain a fallback to newThread(0).
Component: Firefox Sync: Backend → Firefox Sync: Crypto
QA Contact: sync-backend → sync-crypto
Summary: Name Weave/Sync's background thread "gecko.Sync" so it can be identified by OS tools → Name crypto background thread so it can be identified by OS tools
Comment on attachment 484968 [details] [diff] [review]
Name the Weave/Sync background thread "gecko.Sync"

Philipp's comments should be addressed.
Attachment #484968 - Flags: review?(mconnor) → review-
We've backed out off-main-thread crypto since individual calls are so short with all-AES crypto.  INVALID?
Yup.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.