Closed
Bug 606295
Opened 14 years ago
Closed 14 years ago
Don't attempt to remove the edit action listener from nsPlaintextEditor's dtor
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
roc
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
We attempt to remove the edit action listener installed for the nsHTMLEditRules instance associated with nsHTMLEditor here: <http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/nsHTMLEditor.cpp#171>. We also have a similar code in nsPlaintextEditor's dtor: <http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/text/nsPlaintextEditor.cpp#116>. This latter code can be removed, because nsTextEditRules is not an edit action listener, and by the time ~nsPlaintextEditor is executed on an nsHTMLEditor's instance, the edit action listener has already been removed, so there's no point in attempting to remove it again.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #485114 -
Flags: review?(roc)
Attachment #485114 -
Flags: approval2.0?
Attachment #485114 -
Flags: review?(roc)
Attachment #485114 -
Flags: review+
Attachment #485114 -
Flags: approval2.0?
Attachment #485114 -
Flags: approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs landing]
|
|
Assignee | |
Comment 2•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/2eabf911fe1d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [needs landing]
|
||
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•