Closed Bug 606295 Opened 9 years ago Closed 9 years ago

Don't attempt to remove the edit action listener from nsPlaintextEditor's dtor

Categories

(Core :: DOM: Editor, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

We attempt to remove the edit action listener installed for the nsHTMLEditRules instance associated with nsHTMLEditor here: <http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/html/nsHTMLEditor.cpp#171>.  We also have a similar code in nsPlaintextEditor's dtor: <http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/text/nsPlaintextEditor.cpp#116>.

This latter code can be removed, because nsTextEditRules is not an edit action listener, and by the time ~nsPlaintextEditor is executed on an nsHTMLEditor's instance, the edit action listener has already been removed, so there's no point in attempting to remove it again.
Attached patch Patch (v1)Splinter Review
Attachment #485114 - Flags: review?(roc)
Attachment #485114 - Flags: approval2.0?
Attachment #485114 - Flags: review?(roc)
Attachment #485114 - Flags: review+
Attachment #485114 - Flags: approval2.0?
Attachment #485114 - Flags: approval2.0+
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/2eabf911fe1d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
Whiteboard: [needs landing]
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Depends on: 626935
No longer depends on: 626935
You need to log in before you can comment on or make changes to this bug.