606297 - Enable full screen mode on Mac

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Karsten Düsterloh]

Bug 505699 enabled full screen mode on Mac for FF.
We should have that, too, so you can do presentations with your Mac using SM. ;-)

Comment 1

[Stefan [:stefanh]]

Attachment: WIP1

Comment 2

[Stefan [:stefanh]]

Comment on attachment 487442 [details] [diff] [review]
WIP1

Actually, this one should be OK for now, I think. Note that we really want "real" fullscreen in the end, but I think that it's out of scope for this bug. Note also that Mac don't want the close/minimize buttons (I ripped the restore button from Firefox).

Comment 3

[Stefan [:stefanh]]

Comment on attachment 487442 [details] [diff] [review]
WIP1

Neil, I suppose you should have a look at this ;-)

Comment 4

[Karsten Düsterloh]

Comment on attachment 487442 [details] [diff] [review]
WIP1

First, the patch doesn't apply cleanly anymore (but nothing serious).

>+++ b/suite/themes/classic/jar.mn
>+  skin/classic/navigator/icons/restore.gif                              (navigator/icons/restore.gif

Second, my mathematical mind makes me mutter. ;-)
Unclosed braces are so ... missing. *g*

>+#close-button,
> #minimize-button {
>-  list-style-image: url("chrome://navigator/skin/icons/minimize.gif");
>+  display: none;
> } 

Third, did you have a look at Modern as well?
I think close and minimize should be hidden there as well, especially since minimize isn't working at all.

r=me with these fixed.

Comment 5

[Stefan [:stefanh]]

(In reply to comment #4)

> Third, did you have a look at Modern as well?
> I think close and minimize should be hidden there as well, especially since
> minimize isn't working at all.

That would mean that they would be hidden for all OS. Do you really want that?

Comment 6

[[e-mail]]

(In reply to comment #5)
> (In reply to comment #4)
> > Third, did you have a look at Modern as well?
> > I think close and minimize should be hidden there as well, especially since
> > minimize isn't working at all.
> That would mean that they would be hidden for all OS. Do you really want that?
Just use suite/browser/mac/platformNavigationBindings.xul to hide them.

Comment 7

[Karsten Düsterloh]

(In reply to comment #5)
> hidden for all OS. Do you really want that?

Of course not.

Comment 8

[Stefan [:stefanh]]

Attachment: New version using platformNavigationBindings

(In reply to comment #6)
> Just use suite/browser/mac/platformNavigationBindings.xul to hide them.

Ah, right - much cleaner also :-)

Comment 9

[Stefan [:stefanh]]

(also fixed the brace)

Comment 10

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/f8d3569a79a5