Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Enable full screen mode on Mac

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
UI Design
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Karsten Düsterloh, Assigned: stefanh)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.1b2
x86_64
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

12.30 KB, patch
Karsten Düsterloh
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

7 years ago
Bug 505699 enabled full screen mode on Mac for FF.
We should have that, too, so you can do presentations with your Mac using SM. ;-)
Depends on: 505699
(Assignee)

Comment 1

7 years ago
Created attachment 487442 [details] [diff] [review]
WIP1
Assignee: nobody → stefanh
(Assignee)

Comment 2

7 years ago
Comment on attachment 487442 [details] [diff] [review]
WIP1

Actually, this one should be OK for now, I think. Note that we really want "real" fullscreen in the end, but I think that it's out of scope for this bug. Note also that Mac don't want the close/minimize buttons (I ripped the restore button from Firefox).
Attachment #487442 - Flags: review?(mnyromyr)

Updated

7 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

7 years ago
Comment on attachment 487442 [details] [diff] [review]
WIP1

Neil, I suppose you should have a look at this ;-)
Attachment #487442 - Flags: superreview?(neil)
(Reporter)

Comment 4

7 years ago
Comment on attachment 487442 [details] [diff] [review]
WIP1

First, the patch doesn't apply cleanly anymore (but nothing serious).

>+++ b/suite/themes/classic/jar.mn
>+  skin/classic/navigator/icons/restore.gif                              (navigator/icons/restore.gif

Second, my mathematical mind makes me mutter. ;-)
Unclosed braces are so ... missing. *g*

>+#close-button,
> #minimize-button {
>-  list-style-image: url("chrome://navigator/skin/icons/minimize.gif");
>+  display: none;
> } 

Third, did you have a look at Modern as well?
I think close and minimize should be hidden there as well, especially since minimize isn't working at all.

r=me with these fixed.
Attachment #487442 - Flags: review?(mnyromyr) → review+
(Reporter)

Updated

7 years ago
Summary: Full screen mode on Mac → Enable full screen mode on Mac
(Reporter)

Updated

7 years ago
Blocks: 610509
(Assignee)

Comment 5

7 years ago
(In reply to comment #4)

> Third, did you have a look at Modern as well?
> I think close and minimize should be hidden there as well, especially since
> minimize isn't working at all.

That would mean that they would be hidden for all OS. Do you really want that?

Comment 6

7 years ago
(In reply to comment #5)
> (In reply to comment #4)
> > Third, did you have a look at Modern as well?
> > I think close and minimize should be hidden there as well, especially since
> > minimize isn't working at all.
> That would mean that they would be hidden for all OS. Do you really want that?
Just use suite/browser/mac/platformNavigationBindings.xul to hide them.
(Reporter)

Comment 7

7 years ago
(In reply to comment #5)
> hidden for all OS. Do you really want that?

Of course not.
(Assignee)

Comment 8

7 years ago
Created attachment 489212 [details] [diff] [review]
New version using platformNavigationBindings

(In reply to comment #6)
> Just use suite/browser/mac/platformNavigationBindings.xul to hide them.

Ah, right - much cleaner also :-)
Attachment #487442 - Attachment is obsolete: true
Attachment #489212 - Flags: superreview?(neil)
Attachment #487442 - Flags: superreview?(neil)
(Assignee)

Comment 9

7 years ago
(also fixed the brace)
(Reporter)

Updated

7 years ago
Attachment #489212 - Flags: review+

Updated

7 years ago
Attachment #489212 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 10

7 years ago
http://hg.mozilla.org/comm-central/rev/f8d3569a79a5
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
No longer blocks: 467530
(Assignee)

Updated

6 years ago
Depends on: 675690
You need to log in before you can comment on or make changes to this bug.