Closed Bug 606297 Opened 10 years ago Closed 10 years ago

Enable full screen mode on Mac

Categories

(SeaMonkey :: UI Design, defect)

x86_64
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b2

People

(Reporter: mnyromyr, Assigned: stefanh)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 505699 enabled full screen mode on Mac for FF.
We should have that, too, so you can do presentations with your Mac using SM. ;-)
Depends on: 505699
Attached patch WIP1 (obsolete) — Splinter Review
Assignee: nobody → stefanh
Comment on attachment 487442 [details] [diff] [review]
WIP1

Actually, this one should be OK for now, I think. Note that we really want "real" fullscreen in the end, but I think that it's out of scope for this bug. Note also that Mac don't want the close/minimize buttons (I ripped the restore button from Firefox).
Attachment #487442 - Flags: review?(mnyromyr)
Status: NEW → ASSIGNED
Comment on attachment 487442 [details] [diff] [review]
WIP1

Neil, I suppose you should have a look at this ;-)
Attachment #487442 - Flags: superreview?(neil)
Comment on attachment 487442 [details] [diff] [review]
WIP1

First, the patch doesn't apply cleanly anymore (but nothing serious).

>+++ b/suite/themes/classic/jar.mn
>+  skin/classic/navigator/icons/restore.gif                              (navigator/icons/restore.gif

Second, my mathematical mind makes me mutter. ;-)
Unclosed braces are so ... missing. *g*

>+#close-button,
> #minimize-button {
>-  list-style-image: url("chrome://navigator/skin/icons/minimize.gif");
>+  display: none;
> } 

Third, did you have a look at Modern as well?
I think close and minimize should be hidden there as well, especially since minimize isn't working at all.

r=me with these fixed.
Attachment #487442 - Flags: review?(mnyromyr) → review+
Summary: Full screen mode on Mac → Enable full screen mode on Mac
Blocks: 610509
(In reply to comment #4)

> Third, did you have a look at Modern as well?
> I think close and minimize should be hidden there as well, especially since
> minimize isn't working at all.

That would mean that they would be hidden for all OS. Do you really want that?
(In reply to comment #5)
> (In reply to comment #4)
> > Third, did you have a look at Modern as well?
> > I think close and minimize should be hidden there as well, especially since
> > minimize isn't working at all.
> That would mean that they would be hidden for all OS. Do you really want that?
Just use suite/browser/mac/platformNavigationBindings.xul to hide them.
(In reply to comment #5)
> hidden for all OS. Do you really want that?

Of course not.
(In reply to comment #6)
> Just use suite/browser/mac/platformNavigationBindings.xul to hide them.

Ah, right - much cleaner also :-)
Attachment #487442 - Attachment is obsolete: true
Attachment #489212 - Flags: superreview?(neil)
Attachment #487442 - Flags: superreview?(neil)
(also fixed the brace)
Attachment #489212 - Flags: review+
Attachment #489212 - Flags: superreview?(neil) → superreview+
http://hg.mozilla.org/comm-central/rev/f8d3569a79a5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
No longer blocks: FF2SM
Depends on: 675690
You need to log in before you can comment on or make changes to this bug.