60633 - javascript strict warnings in fieldMapImport.js

Status: VERIFIED INVALID

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[Henrik Gemal]

JavaScript strict warning:
chrome://messenger/content/fieldMapImport.js line 79: assignment to undeclared 
variable body

JavaScript strict warning:
chrome://messenger/content/fieldMapImport.js line 80: assignment to undeclared 
variable count

Comment 1

[scottputterman]

reassigning to chuang.

Comment 2

[Mark Olson]

Attachment: proposed patch

Comment 3

[timeless]

r=timeless

Comment 4

[Peter "jag" Annema]

mscott, can you sr=?

Comment 5

[Scott MacGregor]

sr=mscott

Comment 6

[Blake Ross]

Fix checked in.

Comment 7

[Henrik Gemal]

verified with build 20010126 on win2k

Comment 8

[Henrik Gemal]

JavaScript strict warning:
chrome://messenger/content/fieldMapImport.js line 500: reference to undefined 
property body.childNodes[i].firstChild.firstChild.firstChild.checked

BTW: Is the correct procedure to reopen or to open a brand new bug. I heard a 
lot of people saying both...?

Comment 9

[Mark Olson]

I think some people don't like having bugs that are assigned to them reopened
when someone else breaks the code and/or the reason for reopening differs from
the original bug report.  In the case of these javascript warnings reopening
them seems the correct approach to me.

Comment 10

[(not reading, please use [e-mail] instead)]

over to racham, chuang is gone.

Comment 11

[Alex Vincent [:WeirdAl]]

Reporter:  Can you please reconfirm the strict warning in comment #8 above?  I
just looked at
http://lxr.mozilla.org/seamonkey/source/mailnews/import/resources/content/fieldMapImport.js
and there aren't 500 lines in that file anymore...

If this strict warning is reproducible, it should show up as line 479.  I'd like
to see a testcase, please.  :)

Comment 12

[Alex Vincent [:WeirdAl]]

Closing for lack of activity and a reproducible testcase.  If you can see these 
strict warnings, please feel free to REOPEN and provide the testcase, 
please.  :)

Comment 13

[Ninoschka Baca]

Verified Invalid.