606357 - Make JSD work properly with compartments

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

We need to make sure that we actually enter the right compartments in the right places.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

At the very least, we need to go into jsd_val.c and make sure that we enter the right compartment.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fixes v1

This is a first pass of things needed to fix this. The one thing I'm not thrilled about is that I had to fix getWrappedValue all the way out near the XPCOM layer; but by the time we read jsd_val.c from there, we've totally lost which compartment we were called from.

Comment 3

[Damon Sicore (:damons)]

Blake, are there any other fixes that still need to be made here?  In other words, does your first pass fix actually enable JSD to work properly with compartments or do we need more patches?

Comment 4

[Johnny Stenback (:jst)]

Blocking beta7.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Is this ready to land?

Comment 6

[David Mandelin [:dmandelin]]

(In reply to comment #5)
> Is this ready to land?

It did land:

http://hg.mozilla.org/mozilla-central/rev/dd34396ba8d8

But if I try to start a browser (built from m-c tip as of now) with the force-debug-mode patch on, I still get compartment-mismatch assertions:

Assertion failure: compartment mismatched, at c:\sources\mozilla-central\js\src\jscntxtinlines.h:513

Should I file a separate bug on this?

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

I filed bug 607174 on the remaining problems.