Closed
Bug 606389
Opened 14 years ago
Closed 14 years ago
Only eat minidump_stackwalk stderr when there's stdout data
Categories
(Testing :: General, defect)
Testing
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: jruderman)
Details
Attachments
(1 file)
|
2.01 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
I'm running into a problem where fuzz jobs on Linux don't get any output from minidump_stackwalk. It's hard for me to debug it from a distance. To help debug this and similar problems, let's stop eating minidump_stackwalk's stderr when there's no stdout. (The "eat minidump_stackwalk errors" thing goes back to rev a2a7177a218e.)
Attachment #485200 -
Flags: review?(ted.mielczarek)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 485200 [details] [diff] [review] patch (untested) Seems reasonable.
Attachment #485200 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Updated•14 years ago
|
Assignee: nobody → jruderman
|
Assignee | |
Comment 2•14 years ago
|
||
After testing the patch, I realized minidump_stackwalk was crashing for me, so I'm also adding:
if p.returncode != 0:
print "minidump_stackwalk exited with return code %d" % p.returncode|
|
||
Comment 3•14 years ago
|
||
Fine with me.
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/415bf458e0df
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•