606403 - Forget About this Site doesn't purge entries in session history

Status: ASSIGNED

(Toolkit :: Data Sanitization, defect, P3)

Description

[eyal gruss]

i told firefox to forget about some site.
although i navigated away to an innocent url, the criminating evidence still remained in the tab history (back-forward context menu)
bug 464417 suggests to close the tab completely, but until we do so, i think the back-forward context menu should be purged for the offending urls.
Beltzner has asked to file this as a separate bug.

Comment 1

[Dietrich Ayala (:dietrich)]

This is not a regression, so not going to block the release on this. Blocking-.

Comment 2

[eyal gruss]

nominating for future blocking due to privacy concerns

Comment 3

[(no longer active)]

We should really create another bugzilla component for Forget About this Site...

Comment 4

[Marco Bonardo [:mak]]

I'm fine with that, I'm not sure where to put its bugs indeed.

Comment 5

[(no longer active)]

(In reply to Marco Bonardo [:mak] from comment #4)
> I'm fine with that, I'm not sure where to put its bugs indeed.

Filed bug 842399 for that.

Comment 6

[Akylzhan]

Hello, I would like to work on this issue and would like to have some general directions. Also, it seems that clear history does not clear tabs' history, too.

Regarding clearing the tab history, I can see that there is a TabStateCache that seems to be responsible for storing anything related to tabs and would it suffice to call TabStateCache.update(..., {"history": null}) to clear the history?

Comment 7

[Harshit Sohaney]

You can submit a patch and I can review it! I think it's reasonable to remove the tab history of the concerned tab that contains the site we want to forget.
However, I think It'd be nice if we could get rid of just that specific site from the tab history. I would look into the SessionStore code further to investigate this

Comment 8

[Akylzhan]

Hey, Harshit. Thank you very much. Right now, I am struggling to understand how to remove the entries and refresh the browsers. Can you review my code below?
I am planning to put it in this loop

for (let openTab of this._windows[ix].tabs) {
        for (let i = openTab.entries.length - 1; i >= 0; i--) {
          if (containsDomain(openTab.entries[i], this)) {
            refreshWindow = true;
            openTab.entries.splice(i, 1);
          }
        }
      }

Comment 9

[Harshit Sohaney]

Could you put this as a WIP patch on phabricator? It'd be easier for me to see where you're making this change

Comment 10

[Akylzhan]

Attachment: Bug 606403 - Clean history of open tabs. r?hsohaney

Comment 11

[Harshit Sohaney]

Patch was submitted

Comment 12

[Harshit Sohaney]

Hey, are you still working on this, or need any help?