606415 - add tests for calling the post update app and the arguments passed to it

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Robert Strong (they/them - no direct email)]

this will be based on bug 606410

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: Patch in progress

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

Stephen, this along with your patch in bug 1009668 worked for me on both Windows and Mac 10.6.

Comment 5

[Robert Strong (they/them - no direct email)]

Attachment: patch in progress

now with more comments

Comment 6

[Robert Strong (they/them - no direct email)]

note: I'm going to add similar checks to the service tests before requesting review.

Comment 7

[Robert Strong (they/them - no direct email)]

Attachment: patch rev 1

I think this is ready to go though I do have at least one followup to add a couple of more checks to the tests.

Try push including the patch from bug 1009668
https://tbpl.mozilla.org/?tree=Try&rev=969e14b28b5c

Comment 8

[Robert Strong (they/them - no direct email)]

Comment on attachment 8424380 [details] [diff] [review]
patch rev 1

The patch in bug 1009668 needs to be applied before this patch.

Comment 9

[Stephen A Pohl [:spohl]]

Comment on attachment 8424380 [details] [diff] [review]
patch rev 1

Stealing this back.

Comment 10

[Stephen A Pohl [:spohl]]

Comment on attachment 8424380 [details] [diff] [review]
patch rev 1

Review of attachment 8424380 [details] [diff] [review]:
-----------------------------------------------------------------

One minor nit, looks great otherwise. All tests pass with patch in bug 1009668 applied.

::: toolkit/mozapps/update/tests/unit_aus_update/head_update.js
@@ +2190,5 @@
> +  let helperBin = getTestDirFile(FILE_HELPER_BIN);
> +  let afterApplyBinDir = getApplyDirFile("a/b/", true);
> +  helperBin.copyToFollowingLinks(afterApplyBinDir, gCallbackBinFile);
> +
> +  let afterApplyBinDir = getApplyDirFile("a/b/", true);

redefinition from three lines above?

Comment 11

[Robert Strong (they/them - no direct email)]

(In reply to Stephen Pohl [:spohl] from comment #10)
> Comment on attachment 8424380 [details] [diff] [review]
> patch rev 1
> 
> Review of attachment 8424380 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> One minor nit, looks great otherwise. All tests pass with patch in bug
> 1009668 applied.
> 
> ::: toolkit/mozapps/update/tests/unit_aus_update/head_update.js
> @@ +2190,5 @@
> > +  let helperBin = getTestDirFile(FILE_HELPER_BIN);
> > +  let afterApplyBinDir = getApplyDirFile("a/b/", true);
> > +  helperBin.copyToFollowingLinks(afterApplyBinDir, gCallbackBinFile);
> > +
> > +  let afterApplyBinDir = getApplyDirFile("a/b/", true);
> 
> redefinition from three lines above?
Yes and thanks for catching that!

Comment 12

[Robert Strong (they/them - no direct email)]

Attachment: patch with comment addressed

Stephen, if you'd like to land this along with your bug please feel free or let me know and I can land both. Thanks!

Comment 13

[Stephen A Pohl [:spohl]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a13a734672f1

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a13a734672f1