Closed
Bug 606415
Opened 14 years ago
Closed 11 years ago
add tests for calling the post update app and the arguments passed to it
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file, 6 obsolete files)
62.21 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
this will be based on bug 606410
![]() |
Assignee | |
Updated•14 years ago
|
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 1•11 years ago
|
||
![]() |
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8422806 -
Attachment is obsolete: true
![]() |
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8422822 -
Attachment is obsolete: true
![]() |
Assignee | |
Comment 4•11 years ago
|
||
Stephen, this along with your patch in bug 1009668 worked for me on both Windows and Mac 10.6.
Attachment #8423260 -
Attachment is obsolete: true
Attachment #8424305 -
Flags: feedback?(spohl.mozilla.bugs)
![]() |
Assignee | |
Comment 5•11 years ago
|
||
now with more comments
Attachment #8424305 -
Attachment is obsolete: true
Attachment #8424305 -
Flags: feedback?(spohl.mozilla.bugs)
Attachment #8424315 -
Flags: feedback?(spohl.mozilla.bugs)
![]() |
Assignee | |
Comment 6•11 years ago
|
||
note: I'm going to add similar checks to the service tests before requesting review.
![]() |
Assignee | |
Comment 7•11 years ago
|
||
I think this is ready to go though I do have at least one followup to add a couple of more checks to the tests.
Try push including the patch from bug 1009668
https://tbpl.mozilla.org/?tree=Try&rev=969e14b28b5c
Attachment #8424315 -
Attachment is obsolete: true
Attachment #8424315 -
Flags: feedback?(spohl.mozilla.bugs)
Attachment #8424380 -
Flags: review?(spohl.mozilla.bugs)
![]() |
Assignee | |
Comment 8•11 years ago
|
||
Comment on attachment 8424380 [details] [diff] [review]
patch rev 1
The patch in bug 1009668 needs to be applied before this patch.
Attachment #8424380 -
Flags: review?(spohl.mozilla.bugs) → review?(netzen)
Comment 9•11 years ago
|
||
Comment on attachment 8424380 [details] [diff] [review]
patch rev 1
Stealing this back.
Attachment #8424380 -
Flags: review?(netzen) → review?(spohl.mozilla.bugs)
Comment 10•11 years ago
|
||
Comment on attachment 8424380 [details] [diff] [review]
patch rev 1
Review of attachment 8424380 [details] [diff] [review]:
-----------------------------------------------------------------
One minor nit, looks great otherwise. All tests pass with patch in bug 1009668 applied.
::: toolkit/mozapps/update/tests/unit_aus_update/head_update.js
@@ +2190,5 @@
> + let helperBin = getTestDirFile(FILE_HELPER_BIN);
> + let afterApplyBinDir = getApplyDirFile("a/b/", true);
> + helperBin.copyToFollowingLinks(afterApplyBinDir, gCallbackBinFile);
> +
> + let afterApplyBinDir = getApplyDirFile("a/b/", true);
redefinition from three lines above?
Attachment #8424380 -
Flags: review?(spohl.mozilla.bugs) → review+
![]() |
Assignee | |
Comment 11•11 years ago
|
||
(In reply to Stephen Pohl [:spohl] from comment #10)
> Comment on attachment 8424380 [details] [diff] [review]
> patch rev 1
>
> Review of attachment 8424380 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> One minor nit, looks great otherwise. All tests pass with patch in bug
> 1009668 applied.
>
> ::: toolkit/mozapps/update/tests/unit_aus_update/head_update.js
> @@ +2190,5 @@
> > + let helperBin = getTestDirFile(FILE_HELPER_BIN);
> > + let afterApplyBinDir = getApplyDirFile("a/b/", true);
> > + helperBin.copyToFollowingLinks(afterApplyBinDir, gCallbackBinFile);
> > +
> > + let afterApplyBinDir = getApplyDirFile("a/b/", true);
>
> redefinition from three lines above?
Yes and thanks for catching that!
![]() |
Assignee | |
Comment 12•11 years ago
|
||
Stephen, if you'd like to land this along with your bug please feel free or let me know and I can land both. Thanks!
Attachment #8424380 -
Attachment is obsolete: true
Attachment #8427323 -
Flags: review+
Comment 13•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•