Closed Bug 606432 Opened 9 years ago Closed 9 years ago

"ASSERTION: GetOffsetTo called on frames in different documents"

Categories

(Core :: Layout, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: tnikkel)

References

(Blocks 2 open bugs)

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

Attached file testcase
###!!! ASSERTION: GetOffsetTo called on frames in different documents: 'PresContext() == aOther->PresContext()', 
file layout/generic/nsFrame.cpp, line 3749

dbaron just added this assertion:
http://hg.mozilla.org/mozilla-central/rev/d045978f6007

The testcase does *not* cause a hang.
At one point, cross-doc GetOffsetTo was ok.  Did that change?
Yes. I split it into cross-doc and non cross-doc versions because the cross-doc version has to handle the case when zoom changes between documents.
(In reply to comment #0)
> dbaron just added this assertion:
> http://hg.mozilla.org/mozilla-central/rev/d045978f6007

That assertion pertains to views, so its related by slightly different.
So I *thought* the assertion I added would assert in exactly the case where we'd go into infinite recursion.  What did I do wrong?
er, wait, this isn't the assertion I just added, sorry
The caret for the iframe presshell is returning a frame in the parent document. Looks like because it saves the last content it was in and uses that to get the frame. When the content is moved between documents it looks like it doesn't drop it.
Attached patch patchSplinter Review
Assignee: nobody → tnikkel
Attachment #486542 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/f86215099b30
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Hmm, I think the test case for this patch is actually wrong, it executes boom
200ms after the load event, without having set the reftest-wait class...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
You're right.

Pushed this to fix that.
http://hg.mozilla.org/mozilla-central/rev/32cd5d95a95f
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.