606467 - Feedback opens en_US page in localized builds

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tim Babych]

Tested on today's fennec-4.0b2pre.uk.linux-i686.tar.bz2

Comment 1

[Axel Hecht [:Pike]]

What URL would that be? Ad-hoc, can't stab at what to put into an mxr search.

Comment 2

[Tim Babych]

It opens http://m.input.mozilla.com/en-US/happy but it should be http://m.input.mozilla.com/uk/happy

Comment 3

[Axel Hecht [:Pike]]

Both urls in http://mxr.mozilla.org/mobile-browser/source/app/profile/extensions/[e-mail]/content/overlay.xul#61 should not specify a locale at all.

Locale detection ftw :-)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Removes the "en-US" from the URLs. Kinda embarrassed I checked code in like that :(

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #4)
> Created attachment 485289 [details] [diff] [review]
> patch
> 
> Removes the "en-US" from the URLs. Kinda embarrassed I checked code in like
> that :(

You should be like those buttons : 'sad' because this code has been checked in (and i probably should have seen that when i've moved feedback.dtd :( ), 'happy' because this has been corrected soon :)

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/c0a7866940d2

Comment 7

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101025 Namoroka/4.0b8pre Fennec/4.0b2pre

and

Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101025 Namoroka/4.0b8pre Fennec/4.0b2pre