Closed
Bug 606467
Opened 12 years ago
Closed 12 years ago
Feedback opens en_US page in localized builds
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: tim.babych, Assigned: mfinkle)
Details
Attachments
(1 file)
1.75 KB,
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
Tested on today's fennec-4.0b2pre.uk.linux-i686.tar.bz2
Comment 1•12 years ago
|
||
What URL would that be? Ad-hoc, can't stab at what to put into an mxr search.
Reporter | ||
Comment 2•12 years ago
|
||
It opens http://m.input.mozilla.com/en-US/happy but it should be http://m.input.mozilla.com/uk/happy
Comment 3•12 years ago
|
||
Both urls in http://mxr.mozilla.org/mobile-browser/source/app/profile/extensions/feedback@mobile.mozilla.org/content/overlay.xul#61 should not specify a locale at all. Locale detection ftw :-)
tracking-fennec: --- → ?
Assignee | ||
Comment 4•12 years ago
|
||
Removes the "en-US" from the URLs. Kinda embarrassed I checked code in like that :(
Assignee: nobody → mark.finkle
Attachment #485289 -
Flags: review?(21)
Comment 5•12 years ago
|
||
(In reply to comment #4) > Created attachment 485289 [details] [diff] [review] > patch > > Removes the "en-US" from the URLs. Kinda embarrassed I checked code in like > that :( You should be like those buttons : 'sad' because this code has been checked in (and i probably should have seen that when i've moved feedback.dtd :( ), 'happy' because this has been corrected soon :)
Attachment #485289 -
Flags: review?(21) → review+
Assignee | ||
Comment 6•12 years ago
|
||
pushed: http://hg.mozilla.org/mobile-browser/rev/c0a7866940d2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 7•12 years ago
|
||
verified FIXED on builds: Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b8pre) Gecko/20101025 Namoroka/4.0b8pre Fennec/4.0b2pre and Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101025 Namoroka/4.0b8pre Fennec/4.0b2pre
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
tracking-fennec: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•