Daily motion video goes black when coming out of full screen mode

RESOLVED INCOMPLETE

Status

()

Core
Plug-ins
RESOLVED INCOMPLETE
7 years ago
9 months ago

People

(Reporter: aravindm, Assigned: romaxa)

Tracking

({regression})

Trunk
mozilla2.0
x86
Linux
regression
Points:
---

Firefox Tracking Flags

(blocking2.0 .x+)

Details

(Whiteboard: [softblocker], URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101021 Firefox/4.0b8pre

Steps to reproduce :

1. Play any Daily motion video.
2. Go to full screen mode
3. Exit the full screen mode 

Actual results : After exiting the full screen, the video goes black and no sound is heard.

Expected results : Video should play normally when going in and out of full screen mode.

Comment 1

7 years ago
regresson window pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=81c0aef6b272&tochange=8b252736a650
Candidate bug:
Bug 598112 - UseAsyncPainting, always return FALSE because plugin mRunning == FALSE
Blocks: 598112
status2.0: --- → ?
Component: General → Plug-ins
Keywords: regression
Product: Firefox → Core
QA Contact: general → plugins
Target Milestone: --- → mozilla2.0

Updated

7 years ago
blocking2.0: --- → ?
I am not able to reproduce this on Mac using  Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101022 Firefox/4.0b8pre. We should check to see if it happens on Windows.
Alice, did you mean to set status2.0 as "?"

Comment 4

7 years ago
(In reply to comment #3)
> Alice, did you mean to set status2.0 as "?"

mistake
status2.0: ? → ---
Oleg, can you have a look at this regression?
Assignee: nobody → romaxa
blocking2.0: ? → betaN+
(Assignee)

Comment 6

7 years ago
Yes, I'll check it
(Assignee)

Comment 7

7 years ago
Ok, after some investigation I found next problem:

After returning to normal mode from fullscreen flash is waiting Expose/Paint request from browser.... and only after that unpausing video stream and start generate invalidate events.

Without layers we request paint from plugin always because we don't have cached layer, but with layers we do layer repaint only when layer just created or by Plugin InvalidateRect request.

In our case after returning from fullscreen, we repainting black screen layer and not browser not plugin requesting any force-repaint
(Assignee)

Comment 8

7 years ago
Sometime it works but only if plugin had AccumulatedRect before switching to full screen...

Not really sure what is correct way to fix this problem... but we can force plugin repaint when browser receive focus back to main window
(Assignee)

Comment 9

7 years ago
if we remove 
if (!mAccumulatedInvalidRect.IsEmpty()) {
from AsyncShowPluginFrame and PluginInstanceChild::InvalidateRectDelayed

then it will render correctly after returning from fullscreen...

Ideally after returning from fullscreen flash should generate invalidate event...

Updated

7 years ago
Whiteboard: [hardblocker]
Oleg, we're running very low on time to fix this bug. Are you able to finalize this soon (ideally this week)?

Comment 11

7 years ago
I can't reproduce this bug on http://www.dailymotion.com/video/xf9tdc_osama-in-pakistan-cnn_news#hp-v-v1.

Mozilla/5.0 (X11; Linux i686; rv:2.0b11pre) Gecko/20110126 Firefox/4.0b11pre

Comment 12

7 years ago
Created attachment 507412 [details]
screenshot

Mozilla/5.0 (X11; Linux i686; rv:2.0b11pre) Gecko/20110127 Firefox/4.0b11pre ID:20110127030333

After exit full screen mode, I become only the sound.

Shockwave Flash
  File: libflashplayer.so
  Version: 
  Shockwave Flash 10.1 r102

Graphics
  GPU Accelerated Windows 0/1

Comment 13

7 years ago
Oh, I reproduced with 10.1, but I can't with flash 10.2.
WFM too with 10.2, but based on romaxa's description this can be an intermittent problem. This doesn't seem like a hardblocker to me, pushing out.
blocking2.0: betaN+ → final+
Whiteboard: [hardblocker]

Comment 15

7 years ago
(In reply to comment #13)
> Oh, I reproduced with 10.1, but I can't with flash 10.2.

Is 10.2 a stable release? I cannot find it.

Comment 16

7 years ago
It's a RC...
http://labs.adobe.com/technologies/flashplayer10/

Comment 17

7 years ago
Hum, indeed. It works with 10.2, but not with 10.1. If 10.2 is released before Fx 4, then I suppose you don't have anything to do on your side.

Updated

7 years ago
Whiteboard: [softblocker]
** PRODUCT DRIVERS PLEASE NOTE **

This bug is one of 7 automatically changed from blocking2.0:final+ to blocking2.0:.x during the endgame of Firefox 4 for the following reasons:

 - it was marked as a soft blocking issue without a requirement for beta coverage
blocking2.0: final+ → .x+

Comment 19

9 months ago
Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.